Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testbench does not verilate #13

Closed
toddstrader opened this issue Aug 28, 2019 · 2 comments
Closed

Testbench does not verilate #13

toddstrader opened this issue Aug 28, 2019 · 2 comments

Comments

@toddstrader
Copy link
Contributor

The Verilator external test suite is breaking on the SweRV test, and this time I don't believe it is a Verilator regression:
https://travis-ci.com/verilator/verilator_ext_tests/jobs/228899219

It appears that commit 0dacc978 moved finished outside of a macro block that was probably there to get around this issue in the first place. Now Verilator complains that it is defined twice.
aprnath pushed a commit that referenced this issue Sep 4, 2019
Conditioned declaration of finished per issue #13
fc33102
@aprnath
Copy link
Collaborator

aprnath commented Sep 4, 2019

Thanks for reporting this, Todd.
I have pushed a patch for this # fc33102

@toddstrader
Copy link
Contributor Author

Confirmed, thanks:
https://travis-ci.com/verilator/verilator_ext_tests/builds/125826326?utm_medium=notification&utm_source=email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aprnath @toddstrader