Skip to content
This repository has been archived by the owner on Jun 3, 2024. It is now read-only.

Add ImportTypeOfPort test #587

Merged
merged 3 commits into from
Dec 10, 2021
Merged

Conversation

RRozak
Copy link
Collaborator

@RRozak RRozak commented Nov 8, 2021

No description provided.

Signed-off-by: Ryszard Różak <rrozak@antmicro.com>
@@ -0,0 +1,10 @@
package lc_ctrl_pkg;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [verible-verilog-lint] reported by reviewdog 🐶
Package declaration name must match the file name (ignoring optional "_pkg" file name suffix). declaration: "lc_ctrl_pkg" vs. basename(file): "top" [Style: file-names] [package-filename]

@RRozak RRozak removed the request for review from rkapuscik November 8, 2021 13:55
Signed-off-by: Ryszard Różak <rrozak@antmicro.com>
Signed-off-by: Ryszard Różak <rrozak@antmicro.com>
@@ -0,0 +1,10 @@
package lc_ctrl_pkg;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [verible-verilog-lint] reported by reviewdog 🐶
Package declaration name must match the file name (ignoring optional "_pkg" file name suffix). declaration: "lc_ctrl_pkg" vs. basename(file): "top" [Style: file-names] [package-filename]

@@ -0,0 +1,8 @@
package lc_ctrl_pkg;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [verible-verilog-lint] reported by reviewdog 🐶
Package declaration name must match the file name (ignoring optional "_pkg" file name suffix). declaration: "lc_ctrl_pkg" vs. basename(file): "top" [Style: file-names] [package-filename]

@RRozak
Copy link
Collaborator Author

RRozak commented Nov 8, 2021

ImportedParameter test works.

@RRozak
Copy link
Collaborator Author

RRozak commented Nov 8, 2021

ImportParametrizedTypeAndDeclareParamWithTheSameName test waits for chipsalliance/Surelog#2177

@RRozak
Copy link
Collaborator Author

RRozak commented Nov 8, 2021

Maybe the problem with ImportTypeOfPort can be fixed in Verilator, but I think it will be solved by chipsalliance/Surelog#2177 or change after that issue. I will wait with it until it is solved.

@RRozak
Copy link
Collaborator Author

RRozak commented Nov 19, 2021

ImportTypeOfPort still doesn't work. I will later look at it.

@rkapuscik rkapuscik merged commit 5c61617 into chipsalliance:master Dec 10, 2021
@mglb mglb deleted the import_type branch May 31, 2023 01:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants