Merge pull request #1042 from alainmarcel/alainmarcel-patch-1

seq lint rule
chipsalliance · Oct 11, 2023 · cf37173 · cf37173
2 parents 33fabc3 + 1027966
commit cf37173
Show file tree

Hide file tree

Showing 3 changed files with 37 additions and 1 deletion.
diff --git a/templates/Serializer.h b/templates/Serializer.h
@@ -63,7 +63,8 @@ enum ErrorType {
   UHDM_UNDEFINED_VARIABLE = 726,
   UHDM_INVALID_CASE_STMT_VALUE = 727,
   UHDM_UNSUPPORTED_TYPESPEC = 728,
-  UHDM_UNRESOLVED_PROPERTY = 729
+  UHDM_UNRESOLVED_PROPERTY = 729,
+  UHDM_NON_TEMPORAL_SEQUENCE_USE = 730
 };
 
 #ifndef SWIG

diff --git a/templates/UhdmLint.cpp b/templates/UhdmLint.cpp
@@ -246,6 +246,24 @@ void UhdmLint::leaveEnum_typespec(const enum_typespec* object,
   }
 }
 
+class DetectSequenceInst : public VpiListener {
+ public:
+  explicit DetectSequenceInst() {}
+  ~DetectSequenceInst() override = default;
+  void leaveRef_obj(const ref_obj* object, vpiHandle handle) final {
+    if (decl && (seq_parent == nullptr))
+      seq_parent = object;
+  }
+  void leaveSequence_decl(const sequence_decl *object, vpiHandle handle) final {
+    decl = object;   
+  }
+  const sequence_decl* seqDeclDetected() const { return decl; }
+  const ref_obj* parentRef() { return seq_parent; }
+ private:
+  const ref_obj* seq_parent = nullptr;
+  const sequence_decl* decl = nullptr;
+};
+
 void UhdmLint::leaveProperty_spec(const property_spec* prop_s,
                                   vpiHandle handle) {
   if (isInUhdmAllIterator()) return;
@@ -260,6 +278,20 @@ void UhdmLint::leaveProperty_spec(const property_spec* prop_s,
         }
       }
     }
+    {
+      if (prop_s->VpiClockingEvent()) {
+        DetectSequenceInst seqDetector;
+        vpiHandle h = NewVpiHandle(exp);
+        seqDetector.listenAny(h);
+        vpi_free_object(h);
+        if (const sequence_decl* decl = seqDetector.seqDeclDetected()) {
+          const std::string errMsg(decl->VpiName());
+          serializer_->GetErrorHandler()(
+              ErrorType::UHDM_NON_TEMPORAL_SEQUENCE_USE, errMsg,
+              seqDetector.parentRef(), nullptr);
+        }
+      }
+    }
   }
 }
 

diff --git a/util/uhdm-lint.cpp b/util/uhdm-lint.cpp
@@ -166,6 +166,9 @@ int32_t main(int32_t argc, char **argv) {
           case UHDM::UHDM_UNRESOLVED_PROPERTY:
             errmsg = "Unresolved property";
             break;
+          case UHDM::UHDM_NON_TEMPORAL_SEQUENCE_USE:
+            errmsg = "Sequence used in non-temporal context";
+            break;
         }
 
         if (object1) {