Public is Incorrectly Applied to Definitions

[seldridge]

A definition inside a public module (or the top module?) incorrectly gets marked as public. Consider the following:

//> using scala "2.13.12"
//> using repository sonatype-s01:snapshots
//> using lib "org.chipsalliance::chisel::6.0.0+74-0a437d8f-SNAPSHOT"
//> using plugin "org.chipsalliance:::chisel-plugin::6.0.0+74-0a437d8f-SNAPSHOT"
//> using options "-unchecked", "-deprecation", "-language:reflectiveCalls", "-feature", "-Xcheckinit", "-Xfatal-warnings", "-Ywarn-dead-code", "-Ywarn-unused", "-Ymacro-annotations"

import chisel3._
import chisel3.experimental.hierarchy.{
  Definition,
  Instance,
  instantiable
}
import circt.stage.ChiselStage

@instantiable
class Bar extends RawModule

class Foo extends Module {
  private val barDef = Definition(new Bar)
  private val bar = Instance(barDef)
}

object Main extends App {
  println(ChiselStage.emitCHIRRTL(new Foo))
}

This produces the following FIRRTL with scala-cli Foo.scala:

FIRRTL version 4.0.0
circuit Foo :
  public module Bar :

    skip

  public module Foo :
    input clock : Clock
    input reset : UInt<1>

    inst bar of Bar

Module Bar should not be public.