Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

String Parameters not supported with Surelog-yosys Plugin #310

Closed
westonMS opened this issue May 31, 2022 · 4 comments
Closed

String Parameters not supported with Surelog-yosys Plugin #310

westonMS opened this issue May 31, 2022 · 4 comments

Comments

@westonMS
Copy link

Issue

If you use localparam or parameter to initialize parameters, Surelog-yosys plugin throws an error if you initialize it with a string.
The yosys parser is able to correctly interpret this. Both can interpret the parameter correctly if you initialize it with an integer.

Run with command SURELOG_CMD="-parse -DSYNTHESIS" make

Code Example

module top(output logic outLED);

localparam TEST_PARAM = "TestParam.txt";

assign outLED = 1;

endmodule

This code gives the following error:
ERROR: :0: Encountered unhandled typespec in process_parameter: '' of type 'string_typespec'

The Surelog Parser does not throw an error and handles it correctly.

@rkapuscik
Copy link
Contributor

Should be already fixed with chipsalliance/yosys-f4pga-plugins#290, but it seems that the tools in this repository were not updated yet.

@jcrob2
Copy link

jcrob2 commented Jun 17, 2022

Using the following timestamp and hash, the issue still exists.
Timestamp: 20220606-234655
Hash: 1667c14

I've included a file that contains a list of the content/versions of the conda environment that we have.
conda_list.txt

@rkapuscik
Copy link
Contributor

This should be already fixed, please update the plugin to the newest version as described here to verify.

@westonMS
Copy link
Author

I've retested this with the latest install and have verified that it works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants