Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix counter test and openocd instructions #110

Merged
merged 3 commits into from
Dec 21, 2020
Merged

Fix counter test and openocd instructions #110

merged 3 commits into from
Dec 21, 2020

Conversation

acomodi
Copy link
Contributor

@acomodi acomodi commented Dec 21, 2020 •
edited

This PR does the following:

  • adds openocd to the environment
  • fixes link in the README for the bitstream configuration
  • fixes typo in counter tests IOSTANDARD constraints

Fixes #109 and #106

@acomodi
env: xc7: add openocd from litex-hub
49588ba 
Signed-off-by: Alessandro Comodi <acomodi@antmicro.com>
@acomodi
xc7: tests: fix openocd config file link
33d4b26 
Signed-off-by: Alessandro Comodi <acomodi@antmicro.com>
@acomodi
counter_test: fixed typos in IOSTANDARD constraints
9efaf05 
Signed-off-by: Alessandro Comodi <acomodi@antmicro.com>
@acomodi acomodi mentioned this pull request Dec 21, 2020
Open
pabigot
pabigot approved these changes Dec 21, 2020
View reviewed changes
Copy link
Contributor

@pabigot pabigot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed this works for me with the counter example; thanks particularly for the Arty XDC fixes.

@tmichalak tmichalak merged commit 7a43506 into chipsalliance:master Dec 21, 2020
@umarcor umarcor deleted the fix-counter branch March 24, 2022 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pabigot pabigot pabigot approved these changes

@tmichalak tmichalak Awaiting requested review from tmichalak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix counter example
3 participants
@acomodi @pabigot @tmichalak