Use environment variable to access installation directory #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the INSTALL_DIR environment variable Signed-off-by: tjarker <s186083@student.dtu.dk>
|
@acomodi - These changes look correct to me, any idea why the CI is failing? |
|
@mithro only CentOS 8 jobs are failing, due to network issues. See https://github.com/SymbiFlow/symbiflow-examples/runs/5160349223?check_suite_focus=true#step:5:10. See related discussion in Verible: chipsalliance/verible#1165.
|
|
@tjarker can you please rebase? |
|
Superseeded by #296. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
INSTALL_DIRenvironment variable was not used in the portion of the Makefile responsible for downloading to an FPGA. If a path different from the recommended installation path was used, the download make target did not work.I have replaced the relevant parts with the environment variable.