-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework in-docker tests so they handle comments in scripts #67
Conversation
26c25ed
to
2964e04
Compare
@kgugala - I'm okay with this temporary fix, however the |
Well, the original idea for |
@mgielda -- Well, shouldn't bash understand that |
I have forgotten why we needed |
I actually think this is not acceptable to merge and we have to fix the underlying issue. |
2964e04
to
0e4eb9a
Compare
Signed-off-by: Karol Gugala <kgugala@antmicro.com>
0e4eb9a
to
73328e0
Compare
This option is not supported in older distros we test. We need to manually create the directory to which we're going to unpack architectures definitions. Signed-off-by: Karol Gugala <kgugala@antmicro.com>
Ok, now we have a real CI feedback. It seems we have two problems:
I would suggest merging this and open separate issue for (1) -- probably in LiteX using ubuntu:trusty fail as an example. |
fixes #65