-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add fixpoint type to handle conditions #43
Conversation
Hi, Thank you for sending the pull request! It's awesome to see you contributing to this project. However, before I can look at this request you need to add DCO sign-off to commits in this repository. We require DCO sign-off for all commits to this repository (including all authors). Please see the following URL to see more information and BeeWare also have a Beginners guide to DCOs. You can use Thanks! |
69fd745
to
2098871
Compare
Signed-off-by: Christian Lanius <christian.lanius@rwth-aachen.de>
Signed-off-by: Christian Lanius <christian.lanius@rwth-aachen.de>
9373f17
to
f759bbc
Compare
I did the DCO sign-off as requested and I also added a test case, which fails in the current master branch. |
Signed-off-by: Christian Lanius <christian.lanius@rwth-aachen.de>
@kgugala - Could you please review (or assign someone to review)? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@christian-lanius thanks for the PR. Generally looks good. Please see my comments
…ex for it Signed-off-by: Christian Lanius <christian.lanius@rwth-aachen.de>
LGTM. Thanks @christian-lanius |
This pull request fixes issue #42
However it misses a test for this. The previously failing excerpt from my sdf file can be found in the issue. I am unsure how to write set up a proper test for this. Doing it the "simple" way results in a comparison between two equivalent files, which have different white space however.