Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add fixpoint type to handle conditions #43

Merged
merged 4 commits into from
Oct 15, 2020

Conversation

christian-lanius
Copy link
Contributor

This pull request fixes issue #42
However it misses a test for this. The previously failing excerpt from my sdf file can be found in the issue. I am unsure how to write set up a proper test for this. Doing it the "simple" way results in a comparison between two equivalent files, which have different white space however.

@mithro
Copy link
Contributor

mithro commented Oct 14, 2020

Hi,

Thank you for sending the pull request! It's awesome to see you contributing to this project. However, before I can look at this request you need to add DCO sign-off to commits in this repository.

We require DCO sign-off for all commits to this repository (including all authors). Please see the following URL to see more information and BeeWare also have a Beginners guide to DCOs.

You can use git commit --amend --signoff and then a git push --force to add the signoff. You can also use git rebase --signoff.

Thanks!

Signed-off-by: Christian Lanius <christian.lanius@rwth-aachen.de>
Signed-off-by: Christian Lanius <christian.lanius@rwth-aachen.de>
@christian-lanius
Copy link
Contributor Author

I did the DCO sign-off as requested and I also added a test case, which fails in the current master branch.

Signed-off-by: Christian Lanius <christian.lanius@rwth-aachen.de>
@mithro
Copy link
Contributor

mithro commented Oct 14, 2020

@kgugala - Could you please review (or assign someone to review)?

@mithro mithro requested a review from kgugala October 14, 2020 19:10
Copy link
Member

@kgugala kgugala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@christian-lanius thanks for the PR. Generally looks good. Please see my comments

sdf_timing/sdflex.py Outdated Show resolved Hide resolved
sdf_timing/sdflex.py Outdated Show resolved Hide resolved
…ex for it

Signed-off-by: Christian Lanius <christian.lanius@rwth-aachen.de>
@kgugala
Copy link
Member

kgugala commented Oct 15, 2020

LGTM. Thanks @christian-lanius

@kgugala kgugala merged commit 5740ac4 into chipsalliance:master Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants