-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow backslash in string, fixes issue #45 #46
allow backslash in string, fixes issue #45 #46
Conversation
Hi! Thank you for your contribution! You will need to rebase this change before we can merge it. Tim @mithro Ansell |
476bfad
to
f8c73bd
Compare
Signed-off-by: Christian Lanius <christian.lanius@rwth-aachen.de>
f8c73bd
to
5f706d1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like some empty .github/check_license.sh
and .github/check_python_scripts.sh
files where accidentally added?
Yeah, I am currently attempting to figure out what to do with them. They are not empty (as they exist in the repo), but their mode has changed. I'll ping you once I have figured it out. |
Signed-off-by: Christian Lanius <christian.lanius@rwth-aachen.de>
Signed-off-by: Christian Lanius <christian.lanius@rwth-aachen.de>
3513c57
to
9ad24f9
Compare
@kgugala Alright, I fixed the string definition as well as the file mode for the two scripts which I did not touch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This pull request fixes the issue reported in #45 by adding the literal \ (backslash) to the definition of the type STRING. I could not find specifically if "port_instance" in the spec allows for this, but commerical EDA tools support it across the board (and generate such files), thus this library should support it as well.
I have added a testcase in the escaped_name.sdf file, which has crashed before, but has been fixed by the change.
Signed-off-by: Christian Lanius christian.lanius@rwth-aachen.de