Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v2x module tests #18

Merged
merged 212 commits into from
Nov 27, 2019
Merged

v2x module tests #18

merged 212 commits into from
Nov 27, 2019

Conversation

glatosinski
Copy link
Contributor

This package contains the initial implementation of tests for vlog_to_pbtype and vlog_to_model functions. The tests are implemented with use of pytest module. This pull request also adds more test files from https://github.com/SymbiFlow/symbiflow-arch-defs/tree/master/utils/vlog/tests in such a way that the history of those files is preserved.

The tests are in WIP stage due to the lack of XML postprocessing implementation in Python (currently the canonicalizing of XML files was performed with CMake and xsltproc).

gatecat and others added 30 commits November 6, 2019 12:06
@gatecat @glatosinski
Python to generate model.xml from Verilog
e8211fc 
Signed-off-by: David Shah <davey1576@gmail.com>
@gatecat @glatosinski
More pb_type.xml generator code (still unfinished)
d83e697 
Signed-off-by: David Shah <davey1576@gmail.com>
@gatecat @glatosinski
pb_type.xml generation basics implemented
d312b2d 
Signed-off-by: David Shah <davey1576@gmail.com>
@gatecat @glatosinski
Small fixes, add example output
ec643c8 
Signed-off-by: David Shah <davey1576@gmail.com>
@gatecat @glatosinski
Initial support for <mode>, general tidying up and other small tweaks
8a3507d 
Signed-off-by: David Shah <davey1576@gmail.com>
@gatecat @glatosinski
Refactoring, rework how <mode> is specified in the Verilog
8bba290 
Signed-off-by: David Shah <davey1576@gmail.com>
@gatecat @glatosinski
Improve timing-related attribute support
41972d2 
Signed-off-by: David Shah <davey1576@gmail.com>
@gatecat @glatosinski
Add support for combinational delay specification in Verilog
836d967 
Signed-off-by: David Shah <davey1576@gmail.com>
@gatecat @glatosinski
Add support for specifying port_class
01aa320 
Signed-off-by: David Shah <davey1576@gmail.com>
@gatecat @glatosinski
More refactoring and general fixes, including of module types
0730782 
Signed-off-by: David Shah <davey1576@gmail.com>
@gatecat @glatosinski
More small fixes/refactoring
522ae79 
Signed-off-by: David Shah <davey1576@gmail.com>
@gatecat @glatosinski
Naming fixes
1084de6 
Signed-off-by: David Shah <davey1576@gmail.com>
@mithro @glatosinski
sim: Renaming Verilog files.
9cc2708 
 * abc/sim.v -> abc/abc.sim.v

Signed-off-by: Tim 'mithro' Ansell <me@mith.ro>
@gatecat @glatosinski
utils/vlog: Replace ALTERNATIVE_TO attr with MODE parameter
4704c12 
Signed-off-by: David Shah <davey1576@gmail.com>
@gatecat @glatosinski
utils/vlog: Generate XML includes in model.xml where there are Verilo…
bd4f63c 
…g includes

Signed-off-by: David Shah <davey1576@gmail.com>
@gatecat @glatosinski
utils/vlog: Fix model.xml includes and handling of modes
f2e73aa 
Signed-off-by: David Shah <davey1576@gmail.com>
@gatecat @glatosinski
utils/vlog: Remove the test output
b2cbae4 
Signed-off-by: David Shah <davey1576@gmail.com>
@gatecat @glatosinski
utils/vlog: Remove now redundant smoketests
5bffd0d 
Simple tests of the XML from Verilog scripts are now covered
by within testarch instead.

Signed-off-by: David Shah <davey1576@gmail.com>
@mithro @glatosinski
utils/vlog: Tests for vlog_to_XXX based around DSP style blocks.
67afa82 
Signed-off-by: Tim 'mithro' Ansell <me@mith.ro>
@acomodi @glatosinski
utils/vlog: squashed commits from for vlog utility
8284a8b 
Signed-off-by: Alessandro Comodi <acomodi@antmicro.com>
@acomodi @glatosinski
utils/vlog/tests: enabled additional vlog tests
8d54a73 
Signed-off-by: Alessandro Comodi <acomodi@antmicro.com>
@acomodi @glatosinski
utils/vlog: added documentation and all_v2x_tests target
7f274cc 
Signed-off-by: Alessandro Comodi <acomodi@antmicro.com>
@acomodi @glatosinski
utils/vlog: created target to update golden reference
910e432 
Signed-off-by: Alessandro Comodi <acomodi@antmicro.com>
@mithro @glatosinski
utils/vlog: Enable some v2x tests.
8521fed 
Part of Issue #599.

Working;
 * `fig41-full-adder`
 * `fig42-dff`

Still disabled;
 * `dsp_combinational`
 * `dsp_in_registered`
 * `dsp_inout_registered`
 * `dsp_inout_registered_dualclk`
 * `dsp_modes`
 * `dsp_out_registered`
 * `dsp_partial_registered`
 * `simple_pll`

Signed-off-by: Tim 'mithro' Ansell <me@mith.ro>
@mithro @glatosinski
v2x: Fix dff test.
14410e4 
Signed-off-by: Tim 'mithro' Ansell <me@mith.ro>
@mithro @glatosinski
v2x: Enable simple_pll test.
ba3378b 
See issue #633 for more work needed by this test.

Signed-off-by: Tim 'mithro' Ansell <me@mith.ro>
@mithro @glatosinski
v2x: Enable dsp_combinational test.
1e25e95 
Signed-off-by: Tim 'mithro' Ansell <me@mith.ro>
@mithro @glatosinski
v2x: Enable dsp_out_registered test.
00ec24f 
Signed-off-by: Tim 'mithro' Ansell <me@mith.ro>
@acomodi @glatosinski
v2x: updated dsp_out_registered golden pb type
be31e2c 
Signed-off-by: Alessandro Comodi <acomodi@antmicro.com>
@acomodi @glatosinski
v2x: adding update_golden command in v2x cmake
faaa4ac 
Signed-off-by: Alessandro Comodi <acomodi@antmicro.com>
elms and others added 24 commits November 25, 2019 11:40
@elms @glatosinski
utils: minimize flake8 ignores
3cdec70 
Signed-off-by: Elms <elmsfu@freshred.net>
@mithro @glatosinski
Squash everything!
0d8dc52 
Signed-off-by: Tim 'mithro' Ansell <me@mith.ro>
@kgugala @glatosinski
utils: muxgen: generate techmaps for routing muxes
05e8c50 
Signed-off-by: Karol Gugala <kgugala@antmicro.com>
@kgugala @glatosinski
run make format
59f667a 
Signed-off-by: Karol Gugala <kgugala@antmicro.com>
@kgugala @glatosinski
utils: vlog: code cleanup
28a0528 
Signed-off-by: Karol Gugala <kgugala@antmicro.com>
@kgugala @glatosinski
utils: mux_gen: print more meta info in pb_types
8f81dbc 
Signed-off-by: Karol Gugala <kgugala@antmicro.com>
@glatosinski
Added __init__.py file to the v2x/lib directory
aa66809 
Signed-off-by: Grzegorz Latosinski <glatosinski@antmicro.com>
@glatosinski
Changed path to lib in mux_gen.py to a relative path
31d68db 
Signed-off-by: Grzegorz Latosinski <glatosinski@antmicro.com>
@glatosinski
Applied changes recommended by flake8
ee62ffc 
Signed-off-by: Grzegorz Latosinski <glatosinski@antmicro.com>
@glatosinski
Suppressed warnings on line breaks around binary operator
7f67047 
Signed-off-by: Grzegorz Latosinski <glatosinski@antmicro.com>
@glatosinski
Extracted a function for generating mux from the main of mux_gen
b51212b 
Signed-off-by: Grzegorz Latosinski <glatosinski@antmicro.com>
@glatosinski
Added generating mux files before tests
33bae5c 
Signed-off-by: Grzegorz Latosinski <glatosinski@antmicro.com>
@glatosinski
Fixed pipeline and comparator for ordering tests
5f6dee4 
Signed-off-by: Grzegorz Latosinski <glatosinski@antmicro.com>
@glatosinski
Added generating missing pbtype files for tests
54a2238 
Signed-off-by: Grzegorz Latosinski <glatosinski@antmicro.com>
@glatosinski
Improved preparing files for tests
a149f09 
Signed-off-by: Grzegorz Latosinski <glatosinski@antmicro.com>
@glatosinski
Moved final test assertions to the end of the tests
e2dd0b7 
Signed-off-by: Grzegorz Latosinski <glatosinski@antmicro.com>
@glatosinski
Removed empty golden.pb_type.xml file
28cd0cb 
Signed-off-by: Grzegorz Latosinski <glatosinski@antmicro.com>
@glatosinski
Added creating build/ directory for generated test files
70609aa 
Signed-off-by: Grzegorz Latosinski <glatosinski@antmicro.com>
@glatosinski
Fixed generation of pb_types and models in tests
2585132 
Signed-off-by: Grzegorz Latosinski <glatosinski@antmicro.com>
@glatosinski
Dropped testing for Python 3.5
08f21f6 
The resulting XML files for Python 3.5 are different between consecutive
runs, while the version of Yosys and version of lxml (and other
packages) are the same.

Signed-off-by: Grzegorz Latosinski <glatosinski@antmicro.com>
@glatosinski
Minor fix in setup.py
368f758 
Signed-off-by: Grzegorz Latosinski <glatosinski@antmicro.com>
@glatosinski
Dropped testing for Python 3.6
e1832c5 
Testing within Travis CI with Python 3.6 results in error:

"Direct url requirement (like vtr_xml_utils@
git+https://github.com/Symbiflow/vtr-xml-utils) are not allowed for
dependencies"

In Python 3.5 and 3.7 the error does not occur in Travis CI.

Signed-off-by: Grzegorz Latosinski <glatosinski@antmicro.com>
@glatosinski
Comment test dependencies generation
297ac75 
Signed-off-by: Grzegorz Latosinski <glatosinski@antmicro.com>
@glatosinski
Improved the documentation of code for tests
784b302 
Signed-off-by: Grzegorz Latosinski <glatosinski@antmicro.com>
@glatosinski glatosinski force-pushed the v2x-tests branch 2 times, most recently from 4813555 to af86409 Compare November 25, 2019 11:20
@glatosinski
Moved preparation of .travis.yml to a separate script
6e061b1 
Signed-off-by: Grzegorz Latosinski <glatosinski@antmicro.com>
@kgugala kgugala merged commit 7cdb2b8 into chipsalliance:master Nov 27, 2019
@umarcor umarcor deleted the v2x-tests branch May 16, 2022 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mithro mithro mithro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet