Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add license header to top of all code files #39

Merged
merged 7 commits into from
Apr 15, 2020
Merged

Add license header to top of all code files #39

merged 7 commits into from
Apr 15, 2020

Conversation

daniellimws
Copy link
Collaborator

This adds the ISC license header to the python and verilog code files.

Resolve #38

@daniellimws
Add license header to top of all code files
0d9e143 
Resolve chipsalliance#38

Signed-off-by: Daniel Lim Wee Soong <weesoong.lim@gmail.com>
@mithro
Copy link
Collaborator

mithro commented Apr 14, 2020

@daniellimws - Let's go with the short version here?

Copyright (C) 2020  The SymbiFlow Authors.

Use of this source code is governed by a ISC-style
license that can be found in the LICENSE file or at
https://opensource.org/licenses/ISC

@daniellimws
Replace license headers with the shorter version
6ec24bc 
Signed-off-by: Daniel Lim Wee Soong <weesoong.lim@gmail.com>
@daniellimws
Copy link
Collaborator Author

Sure thing

@mithro
Copy link
Collaborator

mithro commented Apr 14, 2020

@daniellimws We should also add the SPDX stuff in f4pga/ideas#47

@daniellimws
Add newline to asserts.py according to PEP8 requirements
d2589e6 
Signed-off-by: Daniel Lim Wee Soong <weesoong.lim@gmail.com>
@daniellimws
Copy link
Collaborator Author

So I will just add SPDX-License-Identifier: MIT to the top of every license header?

@mithro
Copy link
Collaborator

mithro commented Apr 14, 2020

You mean ISC?

@daniellimws
Copy link
Collaborator Author

Oh yes my bad, forgot to change it.

@daniellimws
Add spdx identifier to end of license header
21e695a 
Signed-off-by: Daniel Lim Wee Soong <weesoong.lim@gmail.com>
mithro
mithro reviewed Apr 14, 2020
View reviewed changes
Copy link
Collaborator

@mithro mithro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks pretty good to me!

tests/test_v2x.py Show resolved Hide resolved
v2x/__main__.py Show resolved Hide resolved
v2x/lib/argparse_extra.py Outdated
# ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
# WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
# ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
# OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing SPDX-License-Identifier: ISC

v2x/lib/mux.py Outdated
# ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
# WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
# ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
# OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing SPDX-License-Identifier: ISC

v2x/mux_gen.py Show resolved Hide resolved
v2x/vlog_to_pbtype.py Show resolved Hide resolved
v2x/xmlinc/xmlinc.py Show resolved Hide resolved
v2x/yosys/json.py Show resolved Hide resolved
v2x/yosys/run.py Show resolved Hide resolved
v2x/yosys/utils.py Show resolved Hide resolved
@daniellimws
Add SPDX identifier to end of license header in python files
a832339 
Signed-off-by: Daniel Lim Wee Soong <weesoong.lim@gmail.com>
@daniellimws
Change license headers to shorter version and add spdx identifier
d74fdc3 
Signed-off-by: Daniel Lim Wee Soong <weesoong.lim@gmail.com>
@mithro
Copy link
Collaborator

mithro commented Apr 15, 2020

@daniellimws - I think we figured out that we should add the utf-8 coding thing to the top of all the Python files and also add a hash for that blank line. Then we can merge away!

@daniellimws
Add source code encoding and newline with hash before license
80a5ead 
Signed-off-by: Daniel Lim Wee Soong <weesoong.lim@gmail.com>
mithro
mithro approved these changes Apr 15, 2020
View reviewed changes
Copy link
Collaborator

@mithro mithro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mithro mithro merged commit 60850ef into chipsalliance:master Apr 15, 2020
@daniellimws daniellimws mentioned this pull request Apr 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mithro mithro mithro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add license header to top of all code files
2 participants
@daniellimws @mithro