Add GitHub Actions which publish to PyPI #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mithro
commented
Feb 5, 2021
Closed
mithro
commented
Feb 5, 2021
litghost
reviewed
Feb 5, 2021
mithro
force-pushed
the
github-actions
branch
from
415ea8d
to
b153fef
Compare
Signed-off-by: Tim 'mithro' Ansell <me@mith.ro>
mithro
force-pushed
the
github-actions
branch
3 times, most recently
from
65ba0c7
to
fae3a17
Compare
Signed-off-by: Tim 'mithro' Ansell <me@mith.ro>
Signed-off-by: Tim 'mithro' Ansell <me@mith.ro>
Signed-off-by: Tim 'mithro' Ansell <me@mith.ro>
Signed-off-by: Tim 'mithro' Ansell <me@mith.ro>
Signed-off-by: Tim 'mithro' Ansell <me@mith.ro>
Signed-off-by: Tim 'mithro' Ansell <me@mith.ro>
Fixes chipsalliance#47. Signed-off-by: Tim 'mithro' Ansell <me@mith.ro>
Signed-off-by: Tim 'mithro' Ansell <me@mith.ro>
Signed-off-by: Tim 'mithro' Ansell <me@mith.ro>
Signed-off-by: Tim 'mithro' Ansell <me@mith.ro>
Otherwise on Windows you get errors like; ``` PermissionError: [WinError 5] Access is denied: 'build\\temp.win-amd64-3.6\\Release\\antlr4_runtime\\src\\antlr4_runtime\\.git\\objects\\pack\\pack-65bd2f6de8e3018d18b83281edd60df81726e772.idx' ``` Signed-off-by: Tim 'mithro' Ansell <me@mith.ro>
Signed-off-by: Tim 'mithro' Ansell <me@mith.ro>
Signed-off-by: Tim 'mithro' Ansell <me@mith.ro>
Signed-off-by: Tim 'mithro' Ansell <me@mith.ro>
Signed-off-by: Tim 'mithro' Ansell <me@mith.ro>
Otherwise; ``` D:\a\fasm\fasm\src\ParseFasm.cpp(296,29): error C7555: use of designated initializers requires at least '/std:c++latest' [D:\a\fasm\fasm\build\temp.win-amd64-3.6\Release\parse_fasm_tests.vcxproj] ``` Signed-off-by: Tim 'mithro' Ansell <me@mith.ro>
Otherwise it fails on MacOS X with; ``` error: unknown warning option '-Wimplicit-fallthrough=0'; did you mean '-Wimplicit-fallthrough'? [-Werror,-Wunknown-warning-option] ``` Signed-off-by: Tim 'mithro' Ansell <me@mith.ro>
Signed-off-by: Tim 'mithro' Ansell <me@mith.ro>
mithro
force-pushed
the
github-actions
branch
from
f143d5d
to
78023b0
Compare
Signed-off-by: Tim 'mithro' Ansell <me@mith.ro>
mithro
changed the title
|
@litghost -- As this pull request seems far enough along that someone else can fix the remaining issues and it seems unlikely I'll have time to do it myself, I think we should merge and move forward. Thus, I have logged github issues about the remaining items. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request will add a GitHub Action which builds the fasm packages, including binary wheels for Linux, Mac and Windows and then upload them to PyPI.