Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TopWiring: filter out unnamed declarations when building source lists #2376

Merged
merged 2 commits into from
Sep 29, 2021

Conversation

davidbiancolin
Copy link
Contributor

@davidbiancolin davidbiancolin commented Sep 29, 2021

TopWiring croaks when building up a potential source list because it tries to generate a ComponentName for declarations whose name is the empty string. Since unnamed declarations cannot be targeted anyways (i think?) simply filter them out. This will give a slightly better error message when trying to wire an unsupported declaration.

Subsumes #2372.

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you update the FIRRTL spec to include every new feature/behavior?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you state the API impact?
  • Did you specify the code generation impact?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • bug fix

API Impact

No change.

Backend Code Generation Impact

No change.

Desired Merge Strategy

  • Squash

Release Notes

TopWiring: filter out unnamed declarations when building source lists

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (1.2.x, 1.3.0, 1.4.0) ?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you mark as Please Merge?

Copy link
Contributor

@ekiwi ekiwi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for adding the test!

@ekiwi ekiwi added this to the 1.5.0 milestone Sep 29, 2021
@ekiwi ekiwi added the Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI. label Sep 29, 2021
@mergify mergify bot merged commit 519e8c8 into master Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants