TopWiring: filter out unnamed declarations when building source lists #2376
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TopWiring croaks when building up a potential source list because it tries to generate a
ComponentName
for declarations whose name is the empty string. Since unnamed declarations cannot be targeted anyways (i think?) simply filter them out. This will give a slightly better error message when trying to wire an unsupported declaration.Subsumes #2372.
Contributor Checklist
Type of Improvement
API Impact
No change.
Backend Code Generation Impact
No change.
Desired Merge Strategy
Release Notes
TopWiring: filter out unnamed declarations when building source lists
Reviewer Checklist (only modified by reviewer)
Please Merge
?