Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

env: use prjoxide from conda #38

Merged
merged 2 commits into from
Jun 24, 2021

Conversation

acomodi
Copy link
Contributor

@acomodi acomodi commented Jun 24, 2021

Signed-off-by: Alessandro Comodi acomodi@antmicro.com

Makefile Outdated Show resolved Hide resolved
@acomodi acomodi force-pushed the use-prjoxide-conda-package branch 2 times, most recently from c2ad2dd to db1ec68 Compare June 24, 2021 14:37
Signed-off-by: Alessandro Comodi <acomodi@antmicro.com>
@acomodi acomodi changed the title WIP: test using prjoxide from conda env: use prjoxide from conda Jun 24, 2021
@acomodi acomodi force-pushed the use-prjoxide-conda-package branch from db1ec68 to 70ea2dc Compare June 24, 2021 14:39
@gatecat
Copy link
Contributor

gatecat commented Jun 24, 2021

I think you can also remove the prjoxide git submodule in this patch?

Signed-off-by: Alessandro Comodi <acomodi@antmicro.com>
@acomodi
Copy link
Contributor Author

acomodi commented Jun 24, 2021

I think you can also remove the prjoxide git submodule in this patch?

Indeed, removed.

Copy link
Contributor

@gatecat gatecat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acomodi acomodi merged commit 3b852d6 into chipsalliance:master Jun 24, 2021
@acomodi acomodi deleted the use-prjoxide-conda-package branch June 24, 2021 16:07
@gatecat gatecat mentioned this pull request Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants