Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exhaust Task List Generation #235

Merged
merged 16 commits into from Sep 30, 2020
Merged

Conversation

kamilrakoczy
Copy link
Collaborator

@kamilrakoczy kamilrakoczy commented Sep 21, 2020

Supersede of #227.
Fixes #215

This PR:

  • Updates symbiflow and quicklogic toolchain versions.

  • Adds symbiflow_a200t toolchain to make env.

  • Changes exhaust.py to by default build all possible combinations of board/toolchain/project.

  • Adds --only_required parameter to exhaust.py to build only boards that are defined in project.json as required for CI to be green.

  • Adds nexys-video board.

  • Limits exhaust.py exception message lenght to 300 characters (without this, log from CI weights ~200MB).

@kamilrakoczy kamilrakoczy changed the title [WIP] Exhaust Task List Generation Exhaust Task List Generation Sep 23, 2020
Copy link
Contributor

@acomodi acomodi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's wait for CI

@acomodi
Copy link
Contributor

acomodi commented Sep 24, 2020

I see in CI that the test combination matrix is generated also for the following tests:

  • multiple_tests
  • parameter_tests
  • seed_tests

I think it might be good to add the --only-prefix parameter when invoking these tests as well.

ryancj14 and others added 12 commits September 28, 2020 08:21
Signed-off-by: Ryan Johnson <ryancj14@gmail.com>
Signed-off-by: Ryan Johnson <ryancj14@gmail.com>
Signed-off-by: Ryan Johnson <ryancj14@gmail.com>
Signed-off-by: Kamil Rakoczy <krakoczy@antmicro.com>
Signed-off-by: Kamil Rakoczy <krakoczy@antmicro.com>
Signed-off-by: Kamil Rakoczy <krakoczy@antmicro.com>
Signed-off-by: Kamil Rakoczy <krakoczy@antmicro.com>
Signed-off-by: Kamil Rakoczy <krakoczy@antmicro.com>
Signed-off-by: Kamil Rakoczy <krakoczy@antmicro.com>
Signed-off-by: Kamil Rakoczy <krakoczy@antmicro.com>
Signed-off-by: Kamil Rakoczy <krakoczy@antmicro.com>
Signed-off-by: Kamil Rakoczy <krakoczy@antmicro.com>
Signed-off-by: Kamil Rakoczy <krakoczy@antmicro.com>
Copy link
Contributor

@acomodi acomodi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from some indentation issues.

I see some constraints that differ among toolchains. I assume there are some incompatibilities among them, It would be good to add a comment in each of the "special" constraints to report what XDC command generates the issue for not having a unique constraint file among all the toolchains.

Let's wait for CI.

@@ -0,0 +1,18 @@
## Based on https://github.com/Digilent/digilent-xdc/blob/master/Arty-A7-100-Master.xdc
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this constraint called arty-yosys-vivado instead of arty.xdc only? I would guess that the same constraint file would not work on other toolchains. If not, I think this can be removed.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I left option, to use toolchain-specific constraint file, if for some reason, same constraint file won't work on all toolchains, but in this case, it was some leftover. I removed this file and updated arty.xdc to work on all toolchains

@@ -0,0 +1,80 @@
# Clock Signal
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same thing as above. Is this needed for nextpnr-xilinx only and it does not work for other toolchains?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

Signed-off-by: Kamil Rakoczy <krakoczy@antmicro.com>
Signed-off-by: Kamil Rakoczy <krakoczy@antmicro.com>
Signed-off-by: Kamil Rakoczy <krakoczy@antmicro.com>
@acomodi acomodi merged commit 0e7724d into chipsalliance:master Sep 30, 2020
@umarcor umarcor deleted the task-list branch April 21, 2022 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transition to use an automated circuit/toolhain matrix generation
4 participants