New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exhaust Task List Generation #235
Conversation
1d9f023
to
28a7305
Compare
93a9115
to
5a0e668
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Let's wait for CI
I see in CI that the test combination matrix is generated also for the following tests:
I think it might be good to add the --only-prefix parameter when invoking these tests as well. |
452b592
to
46af0bb
Compare
Signed-off-by: Ryan Johnson <ryancj14@gmail.com>
Signed-off-by: Ryan Johnson <ryancj14@gmail.com>
Signed-off-by: Ryan Johnson <ryancj14@gmail.com>
Signed-off-by: Kamil Rakoczy <krakoczy@antmicro.com>
Signed-off-by: Kamil Rakoczy <krakoczy@antmicro.com>
Signed-off-by: Kamil Rakoczy <krakoczy@antmicro.com>
Signed-off-by: Kamil Rakoczy <krakoczy@antmicro.com>
Signed-off-by: Kamil Rakoczy <krakoczy@antmicro.com>
Signed-off-by: Kamil Rakoczy <krakoczy@antmicro.com>
Signed-off-by: Kamil Rakoczy <krakoczy@antmicro.com>
Signed-off-by: Kamil Rakoczy <krakoczy@antmicro.com>
Signed-off-by: Kamil Rakoczy <krakoczy@antmicro.com>
46af0bb
to
7cb9d54
Compare
Signed-off-by: Kamil Rakoczy <krakoczy@antmicro.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM apart from some indentation issues.
I see some constraints that differ among toolchains. I assume there are some incompatibilities among them, It would be good to add a comment in each of the "special" constraints to report what XDC command generates the issue for not having a unique constraint file among all the toolchains.
Let's wait for CI.
@@ -0,0 +1,18 @@ | |||
## Based on https://github.com/Digilent/digilent-xdc/blob/master/Arty-A7-100-Master.xdc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this constraint called arty-yosys-vivado instead of arty.xdc only? I would guess that the same constraint file would not work on other toolchains. If not, I think this can be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I left option, to use toolchain-specific constraint file, if for some reason, same constraint file won't work on all toolchains, but in this case, it was some leftover. I removed this file and updated arty.xdc
to work on all toolchains
@@ -0,0 +1,80 @@ | |||
# Clock Signal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same thing as above. Is this needed for nextpnr-xilinx only and it does not work for other toolchains?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above.
471d85d
to
33bd728
Compare
Signed-off-by: Kamil Rakoczy <krakoczy@antmicro.com>
Signed-off-by: Kamil Rakoczy <krakoczy@antmicro.com>
Signed-off-by: Kamil Rakoczy <krakoczy@antmicro.com>
Supersede of #227.
Fixes #215
This PR:
Updates symbiflow and quicklogic toolchain versions.
Adds
symbiflow_a200t
toolchain tomake env
.Changes
exhaust.py
to by default build all possible combinations of board/toolchain/project.Adds
--only_required
parameter toexhaust.py
to build only boards that are defined inproject.json
as required for CI to be green.Adds
nexys-video
board.Limits
exhaust.py
exception message lenght to 300 characters (without this, log from CI weights ~200MB).