device_config: allow disabling specific cell to bel mappings #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatecat
reviewed
Apr 28, 2021
fpga_interchange/nextpnr_emit.py
Outdated
| chip_info = populate_chip_info(device, const_ids, global_buffers, | ||
| device_config['buckets'], | ||
| disabled_routethroughs) | ||
| chip_info = populate_chip_info( |
There was a problem hiding this comment.
perhaps at this point it would be neater to pass device_config as-is to populate_chip_info and let it read the various fields?
There was a problem hiding this comment.
Sure, makes total sense, done
acomodi
force-pushed
the
disable-arbitrary-cell-to-bel-maps
branch
from
b10866d
to
7a183ca
Compare
gatecat
approved these changes
Apr 28, 2021
This comes in handy primarly for debugging purposes Signed-off-by: Alessandro Comodi <acomodi@antmicro.com>
acomodi
force-pushed
the
disable-arbitrary-cell-to-bel-maps
branch
from
7a183ca
to
a65c57e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comes in handy primarily for debugging purposes and addresses #71