Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RSD generator #2514

Merged
merged 4 commits into from
Mar 30, 2022
Merged

Fix RSD generator #2514

merged 4 commits into from
Mar 30, 2022

Conversation

shioyadan
Copy link
Contributor

The latest RSD changed the way how source code list is stored, and the generator/rsd does not support the new RSD. This PR fixes the generator and it can obtain RSD source code list correctly again.

  • From my testing, at least verilator seems to be able to correctly parse the RSD.
  • This PR is derived from dependabot/submodules/third_party/cores/rsd-5bc4a20. This branch has not been merged and imports the latest RSD.
  • I do not have sufficient knowledge of the structure of sv-tests, so if any other modifications are needed, I would be grateful for your instructions.

dependabot bot and others added 2 commits March 28, 2022 22:18
@dependabot
Bump third_party/cores/rsd from 8777d59 to 5bc4a20
f87c1e9 
Bumps [third_party/cores/rsd](https://github.com/rsd-devel/rsd) from `8777d59` to `5bc4a20`.
- [Release notes](https://github.com/rsd-devel/rsd/releases)
- [Commits](rsd-devel/rsd@8777d59...5bc4a20)

---
updated-dependencies:
- dependency-name: third_party/cores/rsd
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@shioyadan
Fix RSD generator
0f8886e 
The fixed generator supports rsd-5bc4a20 or later
@shioyadan shioyadan mentioned this pull request Mar 30, 2022
Closed
@tgorochowik
Copy link
Member

Thanks for the fixes! I see that the formatting check still fails. Could you please run make format on your code?

@shioyadan
Copy link
Contributor Author

I'm sorry for making the small commits. I fixed the formatting issue and pushed the fixed version. It appears that all checks, including the formatting check, have passed and some of the runners can now handle RSD correctly.

tgorochowik
tgorochowik approved these changes Mar 30, 2022
View reviewed changes
Copy link
Member

@tgorochowik tgorochowik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks! Let's wait for the current CI run to pass and it should be good to go

@github-actions
Copy link
Contributor

Compared test results

tool new_failures new_passes added removed not_affected
Surelog 0 1 0 0 5127
moore_parse 0 0 0 0 4975
Slang 0 1 0 0 5127
UhdmVerilator 0 0 0 0 5143
Yosys 0 0 0 0 5128
Verilator 0 1 0 0 5142
Slang_parse 0 1 0 0 5065
Icarus 0 0 0 0 4975
Verible 0 1 0 0 4974
Sv2v_zachjs 0 1 0 0 5127
tree_sitter_verilog 0 0 0 0 4975
Odin 0 0 0 0 5066
VanillaYosysUhdmPlugin 0 0 0 0 5128
UhdmYosys 0 0 0 0 5128
VeribleExtractor 0 1 0 0 4974
sv_parser 0 0 0 0 5066
moore 0 0 0 0 5066

Download an archive containing all the details

@tgorochowik tgorochowik merged commit 31c1bb7 into chipsalliance:master Mar 30, 2022
@shioyadan
Copy link
Contributor Author

Thank you very much. I am very happy that my PR has been merged.
The RSD build method may change in the future. If the build method is changed, I would like to create a patch for sv-tests again.

@tgorochowik
Copy link
Member

That would be fantastic, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgorochowik tgorochowik tgorochowik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shioyadan @tgorochowik