Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GLOG currently has trouble with clang-tidy, resulting in clang-diagnostic-error #1434

Open
hzeller opened this issue Sep 8, 2022 · 2 comments

Comments

@hzeller
Copy link
Collaborator

hzeller commented Sep 8, 2022

With the recent update glog ( #1427 ), clang-tidy seems to have an issue:

bazel-out/k8-fastbuild/bin/external/com_github_google_glog/_virtual_includes/glog/glog/logging.h:458:1: error: expected expression [clang-diagnostic-error]
DECLARE_int32(logbuflevel);
^
bazel-out/k8-fastbuild/bin/external/com_github_google_glog/_virtual_includes/glog/glog/logging.h:411:3: note: expanded from macro 'DECLARE_int32'
  DECLARE_VARIABLE(google::int32, I, name, int32)
  ^
bazel-out/k8-fastbuild/bin/external/com_github_google_glog/_virtual_includes/glog/glog/logging.h:401:12: note: expanded from macro 'DECLARE_VARIABLE'
    extern GLOG_EXPORT type FLAGS_##name;                      \

Let's figure out what the reason is.

@hzeller
Copy link
Collaborator Author

hzeller commented Sep 8, 2022

CC: @sschaetz Since you added that, can you have a look ?

You can run it locally by calling

.github/bin/run-clang-tidy.sh

hzeller added a commit to hzeller/verible that referenced this issue Sep 8, 2022
See chipsalliance#1434 for details.

Signed-off-by: Henner Zeller <h.zeller@acm.org>
@hzeller
Copy link
Collaborator Author

hzeller commented Sep 17, 2022

This will be fixed with #1448 so probably no action needed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant