-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Repeated Diagnostic Messages in coc.nvim with Verible Language Server #2164
Comments
On every change of the file, the diagnostics are updated. It seems like your editor does not coalesce these ? There are also two mechanisms diagnostics can be received:
So things do look like they work as intended, just that the editor does not remove the duplicates. I'll have a look if it is possible by the editor to request not auto-publishing diagnostics when it actually does the request by itself (maybe there is a setting the editor can send to the language server). But you should probably also file an issue with your editors' language server implementation to make sure they coalesce the identical diagnostic messages properly or ignore diagnostic notifications when they already request |
The I will file an issue with the language server implementation plugin as well. |
The verible server files the capabilities with I think the server shouldn't use both publishDiagnostics and diagnosticProvider at the same time, or use publishDiagnostics on document didOpen only, and pull mode for onSave and onChange. |
Just chiming in that this is also an issue with https://github.com/neovim/nvim-lspconfig: It's very straightforward to enable: -- ~/.config/nvim/after/plugin/lsp.lua
require'lspconfig'.verible.setup{} I'm not sure what the differences are between the implementation of Verible and other language servers, but this is the only language server that outputs diagnostic messages twice for me. |
So maybe we need to change the language server to not auto-publish findings whenever the editor is in a mode where it actively pulls the diagnostics regardless if there was an auto-diagnostic already sent. |
My IDE is as following:
Repeated Warning Messages
The verible-verilog-ls configurations are as following:
When I created a new
.v
file and typed several spaces, repeated identical warning messages popped up:I expect a single warning message per actual issue per file change or analysis trigger.
After I configured the language server as following in coc.nvim, the second warning message dissapeared.
But I don't think this is an expected behavior or a long-term solution.
Log Messages
Logs of the preceeding different configurations are smilar except the message timestamps and durations.
Verbose logs of the two configurations are also similar except the message timestamps and durations.
The text was updated successfully, but these errors were encountered: