Add Symbol Renaming to the language server #2081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey Jan, I've rebased your #1948 so that it doesn't get lost. |
This is a rebase of original Pull Reqeust chipsalliance#1948 by @jbylicki See commit history there.
hzeller
force-pushed
the
20240128-symbol-rename
branch
from
110e8a7
to
6090dd4
Compare
hzeller
commented
Jan 28, 2024
|
|
||
| // This was ASSERT_FALSE(), but in fact we get the range of 'vara' back, | ||
| // and renaming that actually works. TODO: Check intent of this test. | ||
| ASSERT_TRUE(edit_range.has_value()) << (nlohmann::json)*edit_range; |
There was a problem hiding this comment.
This was testing ASSERT_FALSE(), but it now actually returns a range. Was that #1678 fixing it ?
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2081 +/- ##
==========================================
- Coverage 92.99% 92.97% -0.02%
==========================================
Files 358 358
Lines 26465 26548 +83
==========================================
+ Hits 24611 24683 +72
- Misses 1854 1865 +11 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebase of original Pull Reqeust #1948 by @jbylicki See commit history there.