Updating copyright headers to match current best practices #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkurc-ant
force-pushed
the
update_licensing
branch
2 times, most recently
from
d6fd964
to
357cece
Compare
mithro
reviewed
Apr 21, 2020
LICENSE
Outdated
| @@ -1,4 +1,4 @@ | |||
| Copyright (C) 2019 SymbiFlow Project Authors. All rights reserved. | |||
| Copyright (C) 2019 SymbiFlow Project Authors. | |||
mithro
suggested changes
Apr 22, 2020
There was a problem hiding this comment.
Please go through the checklist at f4pga/ideas#47 and make sure everything is covered then re-request review.
mithro
changed the title
|
The files inside https://github.com/SymbiFlow/vtr-xml-utils/tree/master/tests don't have the headers yet.
|
mkurc-ant
force-pushed
the
update_licensing
branch
from
357cece
to
b128be9
Compare
|
@daniellimws Added the license header to the test script |
|
There's also this in the checklist.
|
mkurc-ant
force-pushed
the
update_licensing
branch
from
b128be9
to
1f4cedd
Compare
|
@daniellimws I've added the |
daniellimws
reviewed
Apr 28, 2020
mkurc-ant
force-pushed
the
update_licensing
branch
2 times, most recently
from
5ba664a
to
2d41858
Compare
daniellimws
suggested changes
Jun 24, 2020
mkurc-ant
force-pushed
the
update_licensing
branch
from
2d41858
to
2a119db
Compare
daniellimws
approved these changes
Jun 24, 2020
|
@mithro Looks like this can be merged already |
|
Please rebase on master |
Signed-off-by: Maciej Kurc <mkurc@antmicro.com>
mkurc-ant
force-pushed
the
update_licensing
branch
from
2a119db
to
1dc8b4f
Compare
Signed-off-by: Maciej Kurc <mkurc@antmicro.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Maciej Kurc mkurc@antmicro.com