Added support for overriding installation path via DESTDIR #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Makefile variable Signed-off-by: Maciej Kurc <mkurc@antmicro.com>
mkurc-ant
force-pushed
the
install-destdir
branch
from
8c973a4
to
a667feb
Compare
FFY00
reviewed
Apr 22, 2022
| EXTRA_FLAGS ?= | ||
|
|
||
| ifdef DESTDIR |
There was a problem hiding this comment.
This is unnecessary, the default value is empty, you can just prepend it where needed. Also, it's better hygiene to just put it in the commands that write to the filesystem, instead of changing the value of PLUGINS_DIR.
There was a problem hiding this comment.
I don't think that I can simply prepend DESTDIR to the path provided by yosys-config --destdir command. The latter is an absolute path. I have to change DATA_DIR because it is referenced in plugin-specific Makefiles to know where to put additional data files.
|
Can we get this merged? The default is not correct for me. |
mglb
pushed a commit
to antmicro/yosys-f4pga-plugins
that referenced
this pull request
Apr 3, 2023
Pin fusesoc version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the
DESTDIRMakefile variable which allows to override the default plugin & data installation path provided byyosys-config.