Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix OOB error in XDC plugin. #9

Merged
merged 2 commits into from Feb 25, 2020
Merged

Fix OOB error in XDC plugin. #9

merged 2 commits into from Feb 25, 2020

Conversation

litghost
Copy link
Contributor

No description provided.

@litghost
Fix OOB error in XDC plugin.
9617598 
Signed-off-by: Keith Rothman <537074+litghost@users.noreply.github.com>
@mithro
Copy link
Collaborator

mithro commented Feb 21, 2020

Should there potentially be a test for this?

@litghost
Copy link
Contributor Author

Should there potentially be a test for this?

I'm not sure how to control how Yosys splits signals. I'll take a look.

tmichalak
tmichalak approved these changes Feb 22, 2020
View reviewed changes
Copy link
Collaborator

@tmichalak tmichalak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. LGTM and most of all everything seems to work now.

@litghost
Move attribute check inside is_signal_port.
48fdeb1 
Signed-off-by: Keith Rothman <537074+litghost@users.noreply.github.com>
@litghost litghost mentioned this pull request Feb 25, 2020
Open
@litghost litghost merged commit 3a95697 into master Feb 25, 2020
@litghost litghost deleted the fix_oob_error branch February 25, 2020 01:49
@litghost litghost mentioned this pull request Feb 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmichalak tmichalak tmichalak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@litghost @mithro @tmichalak