Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full shell support #1

Closed
chipsenkbeil opened this issue Jul 29, 2021 · 6 comments · Fixed by #89
Closed

Full shell support #1

chipsenkbeil opened this issue Jul 29, 2021 · 6 comments · Fixed by #89
Labels
enhancement New feature or request

Comments

@chipsenkbeil
Copy link
Owner

distant shell would be the command to launch a connection to the remote machine.

In terms of manipulating the local tty, we could use crossterm or termion, maybe? Not sure how to simulate the buffer on the other side where the programs are being run (like vim). Would need to look at mosh as an example.

@chipsenkbeil chipsenkbeil added the enhancement New feature or request label Jul 29, 2021
@chipsenkbeil
Copy link
Owner Author

@chipsenkbeil chipsenkbeil added this to the Backlog milestone Aug 15, 2021
@wez
Copy link

wez commented Aug 16, 2021

I'm biased on this, but I'd recommend my own set of crates, which are part of wezterm:

I can point you to an example of an interactive ssh client integrated into the dev CLI that we use at work

@chipsenkbeil
Copy link
Owner Author

chipsenkbeil commented Aug 16, 2021 via email

@kylo252
Copy link

kylo252 commented Oct 19, 2021

Maybe it's worth a considering integrating with https://github.com/zellij-org/zellij.

I have not personally switched to it yet, but it looks very promising. If nothing else it's a good resource to see and learn how they do, or plan to do, some things.

@chipsenkbeil
Copy link
Owner Author

Maybe it's worth a considering integrating with https://github.com/zellij-org/zellij.

I have not personally switched to it yet, but it looks very promising. If nothing else it's a good resource to see and learn how they do, or plan to do, some things.

I'm not familiar with zellij. It's an interesting project, but it looks like their pty logic is baked into their own server, so not something I'd try to integrate into distant. Think I've got a plan laid out for tackling shell implementation. Just need to set aside some time to tackle it!

@github-actions
Copy link

github-actions bot commented Jul 7, 2023

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants