Fix table creation race, add Python 3 compatibility, minor stuff #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise applications using this will have to jump through extra hoops to configure this library's logging
hannes-ucsc
commented
Dec 2, 2017
| timeoutms=30 * 1000, region_name='us-west-2'): | ||
| if holder is None: |
There was a problem hiding this comment.
The default values of keyword arguments are evaluated at function definition time, not function call time. I wasn't sure what your original intention was with the holder. The way it was before all instances of this class in the same process (Python interpreter) would share the same holder unless they explicitly specified one to the constructor. I find that counter-intuitive.
import uuid
def x(x=str(uuid.uuid4())):
return x
x()
'f8fd8b3a-28cb-4f6c-8e0a-9eb45f75ae89'
x()
'f8fd8b3a-28cb-4f6c-8e0a-9eb45f75ae89'
def y(y=None):
return str(uuid.uuid4()) if y is None else y
y()
'ce0a0f00-cfc5-40ea-a2db-6d56b4115e33'
y()
'e7711eaf-851e-4c91-a5e7-a785942ab353'
There was a problem hiding this comment.
didn't consider that it would be used in the same interpreter!
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2
Tested with Python 2.7.10 and 3.6.3