forked from cucumber/cucumber-js
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Use nodejs domain error handler instead of uncaughtError handle
See angular/protractor#876 (specifically [my comment](angular/protractor#876 (comment))). Cucumber uses the top level uncaught error handler to catch exceptions caught by tests. Refer commit cucumber@9091129 and issue cucumber#51. A good approach would be to wrap the test code executions in try/catch blocks and use that exception instead of the `uncaughtException` handler. Another approach is to use the error handler of a nodejs domain instead of the top level global uncaughtException handler. In this commit, I'm using the domain level error handler approach.
- Loading branch information
Showing
2 changed files
with
10 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters