Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compatibility with older gcc bug: unnamed union members cannot be used in init #92

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mckaygerhard
Copy link

...ed in init

This solves compilation in olders gcc due a unresolved bug in <gcc-4.6 that unnamed union members cannot be used in initializer (stupid win-hat developers, always later)

Theres no fun in a cheap software that relies on to high dependences, due high dependences need modern hardware.. an modern hardware dont need memory savings:

so we the users that have older hardware with olders software need this please commit thi for possibility to have compton in many distros that already not have gcc 4.6+.

… used in init

This solves compilation in olders gcc due a unresolved bug in <gcc-4.6 that unnamed union members cannot be used in initializer (stupid win-hat developers, always later)

Theres no fun in a cheap software that relies on to high dependences, due high dependences need modern hardware.. an modern hardware dont need memory savings: so please commit thi for possibility to have compton in many distros that already not have gcc 4.6+.
@richardgv
Copy link
Collaborator

Sorry, but if you couldn't yet clearly see my attitude in #86 and #91, mckaygerhard:

  1. I am not interested in adding dirty workarounds for a 5-year old gcc version.
  2. Aside from the viewpoint of code purity, my main concern is, there could be more than one compiler that tries emulate gcc and declares __GNUC__ and __GNUC_MINOR__. As you may or may not know, clang-3.2 claims it is gcc-4.2, as far as know, with their infinite wisdom.
  3. I believe any a distro that uses <gcc-4.6 should be responsible to add a patch that remove the anonymous union themselves.
  4. Just in case you haven't, please look at how many custom patches Debian, Fedora/RHEL, or Gentoo use on their packages. It seems pretty clear to me that using a custom patch on the distro side is not a major problem nowadays.

Theres no fun in a cheap software that relies on to high dependences, due high dependences need modern hardware.. an modern hardware dont need memory savings:

  1. I don't think a patch creates high dependencies.
  2. Modern hardware may or may not need memory saving, but I believe a modern developer always do.

fruchti pushed a commit to fruchti/compton that referenced this pull request Feb 2, 2019
Previously, compton fails to stop draw_idle in some cases when sw_opti
is enabled.

sw_opti is a feature that limits the draw frequence to vblank frequence.
It adds a delay to drawing when the screen is updated more frequently
than the vblank frequence. However when the delay is not used (i.e. the
screen is updated infrequent enough), compton will start drawing the
frame directly without using the delay. And specically in this case,
compton will fail to stop the draw_idle, causing a callback to be called
once per loop of the mainloop, resulting in high CPU usage.

Fixes chjj#92

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants