Improve the heuristics of the bold broken check #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Putting a span straight in body is not a good check because it will only succeed for a monospaced body font, where the monospace font selection is more likely to be placed on `.terminal`. For better realism still, I’ve put it as a span inside a div inside a div.terminal, which matches what the real terminal will do, so it should be as sound a check as can be done short of doing it on the actual terminal (though quite frankly I don’t see why we don’t just do that).
|
Hmm, I figured non-monospace fonts would still increase the scrollWidth when boldened in broken browsers. Is this not the case for some browsers? It seems to work in practice. edit: Nevermind, I see what you're getting at. This is probably better. |
chjj
added a commit
that referenced
this pull request
Jun 12, 2015
Improve the heuristics of the bold broken check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Putting a span straight in body is not a good check because it will only
succeed for a monospaced body font, where the monospace font selection
is more likely to be placed on
.terminal. For better realism still,I’ve put it as a span inside a div inside a div.terminal, which matches
what the real terminal will do, so it should be as sound a check as can
be done short of doing it on the actual terminal (though quite frankly I
don’t see why we don’t just do that).