(PUP-401) Chocolatey Provider Enhancements #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This sets up the readme appropriately from puppet module generate leaning towards best practices for modules.
- Add operatingsystem_support - Update name of module and all fields to point to chocolatey - Add tags related to Chocolatey
Add skeleton files generated from puppet module generate using @garethr module skeleton - https://github.com/garethr/puppet-module-skeleton
- Update module description. - Add why chocolatey versus the built-in provider. - Update affects section - update usage section - Update reference section - formatting
Attempting to set environment variable for choco location anytime after rspec has loaded all the files is too late as self methods have already executed.
Provide a point that both choco and POSH chocolatey both have the same file. This is the bin shim file choco.exe.
The main command to determine whether choco is on older POSH version or newer C# choco.
Add switches to add when using choco.exe.
- note what version of ruby - use rspec spec instead of rake spec
Cache the results of choco_exe? as a variable so that the command is only run once per session. Allow specs to adjust the return value from choco_exe? to test commands are being set correctly.
Use AllUsersProfile environment variable to determine install location for Chocolatey.
Do not use quotes with non-interpolated strings. This should be a tiny perf bump.
In 176960c, `has_feature :uninstall_options` was added to allow for uninstall_options to be passed. Set the value during uninstall.
Provide the -y for installation with compiled choco.
Provide the -y for uninstallation with compiled choco.
- Provide the -y for upgrade with compiled choco. - Use the new `choco upgrade` command instead of `update`.
Package names are not case sensitive with Chocolatey, so the comparison should not be either.
- Use the new `upgrade --noop` command - Handle the location difference for updated version - Don't add the arguments pipe search
This was referenced Mar 4, 2015
|
i didn't even know you were starting this. awesome sauce. |
|
@rismoney I thought you commented about this the other day - must have been something else? |
|
yea. i was commenting about the choco work. you mentioned the provider, but i did know you started anything on it. :) woot!!! |
Ensure the variable returned is using the full path to choco.exe
Do not specify a source with uninstall on the compiled choco
Update choco to return output for -r no matter what.
This was referenced Mar 18, 2015
This was referenced Mar 30, 2015
On calls to install/upgrade/uninstall, use debug / verbose. On uninstall, also pass force to ensure cleanup of package folder.
Determine which version of Chocolatey is installed and adjust commands accordingly.
The earliest version of Puppet that should be supported will need to be one on Windows that supports 1.9.3, which is likely 3.2.x.
ferventcoder
changed the title
ferventcoder
added a commit
that referenced
this pull request
Mar 30, 2015
…er_enhancements (PUP-401) Chocolatey Provider Enhancements
ferventcoder
pushed a commit
to ferventcoder/puppet-chocolatey
that referenced
this pull request
Dec 6, 2016
…ter/fix_tls (maint) Set TLS 1.1+ When Available (For Ensure Chocolatey Installation)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #50
Closes #43
Closes #18
Closes #52
Closes #15
Closes #26