Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check for installed packages is case sensitive #43

Closed
wjrogers opened this issue Dec 10, 2014 · 3 comments · Fixed by #49
Closed

check for installed packages is case sensitive #43

wjrogers opened this issue Dec 10, 2014 · 3 comments · Fixed by #49

Comments

@wjrogers
Copy link
Contributor

The provider method that parses chocolatey output for the list of installed packages uses case sensitive string matching. Chocolatey, like most of Windows, is not case sensitive. This can lead to a situation where the provider appears to work (the package gets installed), but it can't tell that the package is installed, so it tries to install it again every run, delaying the puppet agent run by a long time. This may also be the root cause of the apparently spurious messages discussed in issue #36.

I think the provider's check for installed packages should be case _in_sensitive for ease of use and reliability, especially because the correct case for packages names is somewhat obscure when browsing packages on chocolatey.org.

@rismoney
Copy link
Contributor

This is an easy fix. I personally prefer to match case.

@rismoney
Copy link
Contributor

i will force a downcase on both sides of the conditional. This should have the net/net effect of case insensitivity.

@ferventcoder
Copy link
Contributor

This will close with #49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants