Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(graphviz) 2.44.1 looks broken #1580

Closed
CAMOBAP opened this issue Nov 24, 2020 · 8 comments
Closed

(graphviz) 2.44.1 looks broken #1580

CAMOBAP opened this issue Nov 24, 2020 · 8 comments
Assignees
Labels

Comments

@CAMOBAP
Copy link

CAMOBAP commented Nov 24, 2020

choco install graphviz produce

C:\Windows\system32>choco install graphviz
Chocolatey v0.10.15
Installing the following packages:
graphviz
By installing you accept licenses for the packages.
Progress: Downloading Graphviz 2.44.1... 100%

Graphviz v2.44.1 [Approved]
graphviz package files install completed. Performing other installation steps.
The package Graphviz wants to run 'chocolateyInstall.ps1'.
Note: If you don't run this script, the installation will fail.
Note: To confirm automatically next time, use '-y' or consider:
choco feature enable -n allowGlobalConfirmation
Do you want to run the script?([Y]es/[A]ll - yes to all/[N]o/[P]rint): Y

Attempt to use original download file name failed for 'C:\ProgramData\chocolatey\lib\Graphviz\tools\graphviz-install-2.44.1-win64.exe'.
Copying graphviz
  from 'C:\ProgramData\chocolatey\lib\Graphviz\tools\graphviz-install-2.44.1-win64.exe'
Installing graphviz...
graphviz has been installed.
WARNING: Can't find graphviz install location
 The install of graphviz was successful.
  Software installed as 'exe', install location is likely default.

Chocolatey installed 1/1 packages.
 See the log for details (C:\ProgramData\chocolatey\logs\chocolatey.log).

chocolatey.log

Version v2.38.0.20190211 works without any issues

Expected Behavior

dot tool should be available after graphviz install

Current Behavior

Formally the installation finished successfully but in fact, the dot tool has not ben installed

Possible Solution

IDK, but if I run %USERPROFILE%\AppData\Local\Temp\chocolatey\Graphviz\2.44.1\graphvizInstall.exe without /S it works

Steps to Reproduce (for bugs)

  1. choco install graphviz --version 2.44.1
  2. check output
  3. also you may checkdot -?, it not found

Your Environment

  • Package Version used: 2.44.1
  • Operating System and version: Windows 10
  • Chocolatey version: 0.10.15
  • Install/uninstall gist:
@majkinetor
Copy link
Contributor

The installer didn't find installation path so it couldn't add shim to the PATH.

Dot is probably there.

Definitely a bug due to recent release.

@majkinetor majkinetor added the Bug label Nov 24, 2020
@majkinetor majkinetor self-assigned this Nov 24, 2020
@CAMOBAP
Copy link
Author

CAMOBAP commented Nov 24, 2020

Dot is probably there.

@majkinetor I can confirm that there is no dot.exe in chocolatey's bin directory

@majkinetor
Copy link
Contributor

Not in bin directory, its there on the system.

@CAMOBAP
Copy link
Author

CAMOBAP commented Nov 24, 2020

@majkinetor you are right, it's in "Programm Files".

But for "v2.38.0.20190211" dot was in chocolatey's bin. If this new behavior is expected, feel free to close this ticket (or I can do this if you confirm this)

@majkinetor
Copy link
Contributor

No, its a bug. I will fix it ASAP.

@majkinetor majkinetor changed the title graphviz 2.44.1 looks broken (graphviz) 2.44.1 looks broken Nov 24, 2020
majkinetor added a commit that referenced this issue Nov 24, 2020
majkinetor added a commit that referenced this issue Nov 24, 2020
@majkinetor
Copy link
Contributor

majkinetor commented Nov 24, 2020

Try it now please. It should be fixed:

https://chocolatey.org/packages/Graphviz/2.44.1.20201124

cinst graphviz --version 2.44.1.20201124

graphviz v2.44.1.20201124 (forced)
graphviz package files install completed. Performing other installation steps.
Attempt to use original download file name failed for 'C:\ProgramData\chocolatey\lib\graphviz\tools\graphviz-install-2.44.1-win64.exe'.
Copying graphviz
  from 'C:\ProgramData\chocolatey\lib\graphviz\tools\graphviz-install-2.44.1-win64.exe'
Installing graphviz...
graphviz has been installed.
graphviz installed to 'C:\Program Files\Graphviz 2.44.1'
Added C:\ProgramData\chocolatey\bin\dot.exe shim pointed to 'c:\program files\graphviz 2.44.1\bin\dot.exe'.

@CAMOBAP
Copy link
Author

CAMOBAP commented Nov 24, 2020

@majkinetor thank you a lot

@majkinetor
Copy link
Contributor

No problem mate. Keep up the good work with your projects (always happy to see more doc generators).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants