Moved CutePDF to AU. #380

mikecole · 2016-11-08T01:04:43Z

No description provided.

majkinetor · 2016-11-08T06:33:41Z

automatic/PDFCreator/PDFCreator.nuspec

@@ -17,8 +17,4 @@ PDFCreator – PDFCreator easily creates PDFs from any Windows program. Use it l
    <tags>pdf admin</tags>
    <packageSourceUrl>https://github.com/chocolatey/chocolatey-coreteampackages</packageSourceUrl>


https://github.com/chocolatey/chocolatey-coreteampackages/tree/master/automatic/PDFCreator

Its also good chance (although not mandatory) to update other metadata:

Give some features

Add some more tags such as editor, office, fos etc.

Add docs, bugtrackerurl, mailinglist etc.

Also, its open source so, projectsSourceUrl: https://github.com/pdfforge/PDFCreator

I was going more for a 1-1 conversion from ketarin to AU, but I'll add these.

This migration to AU is perfect time to tidy up metadata. You need to revisit everything anyway, and those information are really handy to have in choco info <package> or on site directly.

majkinetor · 2016-11-08T06:46:07Z

automatic/PDFCreator/update.ps1

+    $temp_file = $env:TEMP + '\PDFCreator.exe'
+    Invoke-WebRequest $url -OutFile $temp_file
+
+    $version = (Get-Command $temp_file).Version


Interesting way to obtain the version. I like it.

However, its not appropriate here. The file size is ~27MB and the version is available on download page.

So you should find out something that produces faster update:

Download page has info about the version.

Blog seems to serve as release new information: http://www.pdfforge.org/blog, so you can take in their RSS feed (http://www.pdfforge.org/blog/rss) and filter items with PDFCreator in title and get the version.

The download page gives me 2.4. The blog gives me 2.4.0. Getting the version from the installer gives me 2.4.0.213. I wasn't sure what level of detail was most appropriate, so I went with most detailed. What is your opinion on which version is appropriate?

Its a good find. I had a same problem with LibreOffice - on site it was one version and install adds revision number. It was important to recognize what you had in order not to download if not needed. However, your solution downloads too, so it doesn't make a difference. But its great solution when its very hard to parse the version or if its impossible.

Just go with the site 2.4 or blog 2.4.0 (site is probably what is expected by users tbh). Its better not to add revision as it can be used for choco fix.

I would go with 2.4.0, I.e. What comes from the blog post.

OK, I can look at the RSS feed for the first title that contains "released" and extract the version. It might not be perfect, but it's probably good enough.

@majkinetor ok, I have to ask, why is 2.5 not the same as 2.5.0? In one, the patch version is explicitly being stated as 0, and the other, it just isn't being shown.

The suggestion wasn't to simply add a .0, but rather, if the version number is a 2 part version number, add the .0 onto it.

The suggestion wasn't to simply add a .0, but rather, if the version number is a 2 part version number, add the .0 onto it.

I think this is irrelevant. Why should we do this ?

ok, I have to ask, why is 2.5 not the same as 2.5.0?

Because [version]2.5 -ne [version]2.5.0 :)

@majkinetor ah, I see the problem here... We are not talking about the same thing. I was talking about Semantic Versioning.

I see the PDF creator uses minimum tree part version, probably best to follow the existing convention.
https://chocolatey.org/packages/PDFCreator

That makes sense.

majkinetor · 2016-11-08T07:31:33Z

In advance, please use separate PR for each package, please.

mikecole · 2016-11-08T14:20:16Z

Sorry, didn't realize two packages snuck into this pull request.

majkinetor · 2016-11-08T18:15:22Z

@mikecole I referenced few issues reported for those packages. Would u please take a look?

mikecole · 2016-11-08T18:17:34Z

Sure will. Thanks!

On Tue, Nov 8, 2016 at 12:15 PM, Miodrag Milić notifications@github.com
wrote:

@mikecole https://github.com/mikecole I referenced few issues reported
for those packages. Would u please take a look?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#380 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABHL603513scnvST2XsxKFvYvgiZsT1Eks5q8Lw7gaJpZM4Kr6k1
.

mikecole · 2016-11-11T04:48:04Z

@majkinetor I believe I fixed both linked issues.

majkinetor · 2016-11-11T09:54:36Z

automatic/PDFCreator/update.ps1

+function global:au_SearchReplace {
+    @{
+        'tools\ChocolateyInstall.ps1' = @{
+            "(^[$]checksum\s*=\s*)('.*')"   = "`$1'$($Latest.Checksum32)'"


You don't have an URL here. It will never update it.

majkinetor · 2016-11-11T09:55:42Z

automatic/cutepdf/update.ps1

+function global:au_GetLatest {
+    Write-Host $url
+
+    $temp_file = $env:TEMP + '\CuteWriter.exe'


The same as before here, without downloading the files if other things are possible.

mikecole · 2016-11-12T03:00:56Z

@majkinetor fixed and fixed.

majkinetor · 2016-11-12T10:21:22Z

automatic/PDFCreator/PDFCreator.nuspec

@@ -14,11 +14,9 @@
 PDFCreator – PDFCreator easily creates PDFs from any Windows program. Use it like a printer in Word, StarCalc or any other Windows application.
    </description>
    <summary>PDFCreator - PDFCreator easily creates PDFs from any Windows program.</summary>
-    <tags>pdf admin</tags>
-    <packageSourceUrl>https://github.com/chocolatey/chocolatey-coreteampackages</packageSourceUrl>
+    <tags>pdf editor printer admin</tags>


Should be tagged with fos.

that would actually be foss, fos means something completely different

Yeah, my bad.. foss

majkinetor · 2016-11-12T10:26:37Z

automatic/PDFCreator/update.ps1

+    return @{ URL = $url; Version = $version }
+}
+
+update -NoCheckUrl -ChecksumFor 32


AU complains about URLs ? hence NoCheckUrl ?

No, that was copied and pasted from another package. I'll fix it.

majkinetor · 2016-11-12T10:29:09Z

automatic/PDFCreator/PDFCreator.nuspec

@@ -14,11 +14,9 @@
 PDFCreator – PDFCreator easily creates PDFs from any Windows program. Use it like a printer in Word, StarCalc or any other Windows application.


Please add ##Features (link)

majkinetor · 2016-11-12T10:30:51Z

automatic/cutepdf/cutepdf.nuspec

    <title>CutePDF</title>
-    <version>{{PackageVersion}}</version>
+    <version>3.0</version>
    <authors>Acro Software Inc.</authors>
    <owners>Redsandro</owners>
    <summary>Free PDF printer driver with no watermarks.</summary>


Please add '##Features'

majkinetor · 2016-11-12T10:33:01Z

automatic/cutepdf/cutepdf.nuspec

@@ -1,10 +1,9 @@
 <?xml version="1.0" encoding="utf-8"?>
-<!-- Do not remove this test for UTF-8: if “Ω” doesn’t appear as greek uppercase omega letter enclosed in quotation marks, you should use an editor that supports UTF-8, not this one. -->
 <package xmlns="http://schemas.microsoft.com/packaging/2010/07/nuspec.xsd">


Add freeware among tags.

majkinetor · 2016-11-12T10:44:34Z

Also, add releaseNotes. I see that CutePDF has them at http://www.cutepdf.com/support/updates.asp and the other package certainly has it.

Those are all metadata problems. When you fix it I will merge it.

gep13 · 2016-11-13T21:54:00Z

@mikecole are you in a position to update this PR with the suggestions, or are you happy for us to make the modifications and merge?

mikecole · 2016-11-14T04:23:58Z

@gep13 yes I can fix these in the next few days, unless you'd like them sooner.

mikecole added 2 commits November 7, 2016 19:02

Moved CutePDF to AU.

2af5646

Converted PDFCreator to AU.

db466cb

majkinetor reviewed Nov 8, 2016

View reviewed changes

majkinetor mentioned this pull request Nov 8, 2016

PDFCreator problems #243

Closed

majkinetor mentioned this pull request Nov 8, 2016

PDFCreator: settings lost after each update #57

Closed

mikecole added 6 commits November 10, 2016 09:52

Added more metadata to pdfcreator nuspec.

b7d99a4

Modified PDFCreator AU update script.

9ded547

Upgraded PDFCreator AU update script.

eb5164a

Updated PDFCreator to 2.4.0.

688230b

Adjusted PDFCreator install script to not remove settings on upgrade.

faae0bc

Merge remote-tracking branch 'refs/remotes/chocolatey/master'

9425e46

Removed old ketarin settings.

331d3aa

majkinetor reviewed Nov 11, 2016

View reviewed changes

mikecole added 2 commits November 11, 2016 20:27

Added URL to PDFCreator SearchReplace method

d28f422

Updated cutepdf au.

cb199a1

majkinetor reviewed Nov 12, 2016

View reviewed changes

mikecole added 2 commits November 16, 2016 21:41

Improved CutePDF and PDFCreator.

a5bc67e

Improved PDFCreator.

3108c95

majkinetor merged commit 60020b1 into chocolatey-community:master Nov 19, 2016

		@@ -17,8 +17,4 @@ PDFCreator – PDFCreator easily creates PDFs from any Windows program. Use it l
		<tags>pdf admin</tags>
		<packageSourceUrl>https://github.com/chocolatey/chocolatey-coreteampackages</packageSourceUrl>

		@@ -14,11 +14,9 @@
		PDFCreator – PDFCreator easily creates PDFs from any Windows program. Use it like a printer in Word, StarCalc or any other Windows application.

Moved CutePDF to AU. #380

Moved CutePDF to AU. #380

Conversation

mikecole commented Nov 8, 2016

Choose a reason for hiding this comment

majkinetor Nov 8, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

majkinetor Nov 8, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

majkinetor Nov 8, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

majkinetor commented Nov 8, 2016

mikecole commented Nov 8, 2016

majkinetor commented Nov 8, 2016

mikecole commented Nov 8, 2016

mikecole commented Nov 11, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mikecole commented Nov 12, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

majkinetor Nov 12, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

majkinetor commented Nov 12, 2016

gep13 commented Nov 13, 2016

mikecole commented Nov 14, 2016

majkinetor Nov 8, 2016 •

edited

Loading

majkinetor Nov 8, 2016 •

edited

Loading

majkinetor Nov 8, 2016 •

edited

Loading

majkinetor Nov 12, 2016 •

edited

Loading