Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tile View - Prevent Version text overlap #651

Closed
iessa-pragg-ctct opened this issue Feb 25, 2019 · 20 comments
Closed

Tile View - Prevent Version text overlap #651

iessa-pragg-ctct opened this issue Feb 25, 2019 · 20 comments
Assignees
Labels
Improvement Issues that enhances existing functionality, or adds new features
Milestone

Comments

@iessa-pragg-ctct
Copy link

iessa-pragg-ctct commented Feb 25, 2019

Packages with particularly long version indicators clash in the tile view when they have updates available.

Environment

Win 10 Pro
ChocolateyGUI 0.16.0

chocolatey-gui-version-collision-ui-issue

@gep13
Copy link
Member

gep13 commented Feb 25, 2019

@punker76 If you have some time, what are your thoughts on this?

@punker76 punker76 self-assigned this Feb 25, 2019
@gep13
Copy link
Member

gep13 commented Apr 23, 2019

@CTCTIPragg I can confirm that this remains an issue in the latest pre-release version of Chocolatey GUI.

@punker76 do you have any suggestions on how best to approach this?

@punker76
Copy link
Member

punker76 commented Apr 23, 2019

So after some UI brain storming with @gep13 here are some options to improve these update situation for the tile view:

  • Prefered option for me and Gary
    Left aligned version informations above the title.

2019-04-23_11h18_52

  • Left aligned version informations under the title.
    2019-04-23_11h32_07
  • Right aligned version informations above the (centered) title.

2019-04-23_10h48_13

  • Right aligned version informations under the (centered) title.

2019-04-23_11h00_03

@pascalberger @ferventcoder @mwallner What do you think about that?

@pascalberger
Copy link
Contributor

From the four options I agree with both of you for the left aligned version information above the title option.

Another idea: Title on top (above icon), version at the bottom

@mwallner
Copy link
Member

all versions look good imo, although @pascalberger could have a point with placing the title above the icon ...

@gep13
Copy link
Member

gep13 commented Apr 24, 2019

@pascalberger said...
Another idea: Title on top (above icon), version at the bottom

Oooo, I think I like that...

@punker76 could you create another screenshot with that option? Sorry to be a pain!

@punker76
Copy link
Member

@punker76
Copy link
Member

@gep13 @pascalberger @mwallner

Also possible with a little bit opacity for the 'Out Of Date' ('Installed') overlay

image

@AdmiringWorm
Copy link
Member

AdmiringWorm commented Apr 24, 2019

@punker76 the title seems a little out of place when it is above the icon (IMO). Would it be better to have that centred?

When it comes to short package titles

@punker76
Copy link
Member

@gep13 @pascalberger @mwallner @AdmiringWorm

So, like this...

2019-04-24_17h14_55

2019-04-24_17h15_12

@AdmiringWorm
Copy link
Member

Personally, I think that looks good (not considering the "Out of date" overlay of course)

@pascalberger
Copy link
Contributor

Centered title looks generally better IMHO, except when there is an overlay. Would it be possible to move the overlay to the bottom right corner, as this is the place where there is most whitespace?

@AdmiringWorm
Copy link
Member

AdmiringWorm commented Apr 24, 2019

Or have the overlay go underneath the text?
Not sure if that would be any better 🤔

pascalberger's suggestion would probably be better

@gep13
Copy link
Member

gep13 commented Apr 24, 2019

@pascalberger said...
Would it be possible to move the overlay to the bottom right corner, as this is the place where there is most whitespace?

That would start to have the same problem when there is a large version number, for example on GitVersion.

@pascalberger
Copy link
Contributor

That would start to have the same problem when there is a large version number, for example on GitVersion.

Sure, but only with large version numbers. Which I assume is less often the case than large titles

@punker76
Copy link
Member

image

@gep13
Copy link
Member

gep13 commented Apr 24, 2019

@pascalberger said...
Which I assume is less often the case than large titles

Yes, that is a valid point!

@gep13
Copy link
Member

gep13 commented Apr 25, 2019

@punker76 I think I like the final option:

  • Package Name on Top
  • Version numbers in lower left cornet
  • Out of Date/Installed overlays on the bottom right hand corner

Would you be able to update the PR to reflect this?

@punker76
Copy link
Member

@punker76 I think I like the final option:

  • Package Name on Top
  • Version numbers in lower left cornet
  • Out of Date/Installed overlays on the bottom right hand corner

Would you be able to update the PR to reflect this?

Yes, I'll do a PR as soon as I can.

@gep13 gep13 added the Improvement Issues that enhances existing functionality, or adds new features label Apr 25, 2019
@gep13 gep13 added this to the 0.17.0 milestone Apr 25, 2019
punker76 added a commit to punker76/ChocolateyGUI that referenced this issue Apr 25, 2019
So that the latest Version do not overlap the current Version when an update is available.
Version numbers now in lower left corner. Also move the package name on top and the Out of Date/Installed overlays on the bottom right hand corner.
gep13 pushed a commit that referenced this issue Apr 25, 2019
So that the latest Version do not overlap the current Version when an update is available.
Version numbers now in lower left corner. Also move the package name on top and the Out of Date/Installed overlays on the bottom right hand corner.
gep13 added a commit that referenced this issue Apr 25, 2019
* pr662:
  (GH-651) Improve Tile View So that the latest Version do not overlap the current Version when an update is available. Version numbers now in lower left corner. Also move the package name on top and the Out of Date/Installed overlays on the bottom right hand corner.
@gep13 gep13 closed this as completed Apr 25, 2019
@gep13 gep13 changed the title Tile View - Version text overlap Tile View - Prevent Version text overlap Mar 26, 2020
@choco-bot
Copy link

🎉 This issue has been resolved in version 0.17.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Issues that enhances existing functionality, or adds new features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants