(GH-588) Add option to search packages in all available repositories #591
Conversation
mwallner
added
the
Feature
mwallner
removed
the
Feature
gep13
changed the title
|
@mwallner am I missing something here? Or where are you actually telling it to search all repositories? Perhaps we can talk about this one when we have a chat? |
|
hey @gep13 - since I'm pretty busy currently here the explanation: (the logic is inverse - if "search in all repos" is active - the source to look in is not set - otherwise it will be fixed to the currently active) |
| @@ -17,5 +17,7 @@ public class AppConfiguration | |||
| public bool DefaultToTileViewForRemoteSource { get; set; } | |||
|
|
|||
| public bool UseDelayedSearch { get; set; } | |||
|
|
|||
| public bool SearchInAllRepositories { get; set; } | |||
There was a problem hiding this comment.
Is this the right terms here? Chocolatey GUI doesn't refer to repositories, but rather Sources. Should this be SearchInAllRepositories?
There was a problem hiding this comment.
I'm with @gep13 , so SearchInAllSources could be the name...
| @@ -15,7 +15,8 @@ public struct PackageSearchOptions | |||
| bool includePrerelease, | |||
| bool includeAllVersions, | |||
| bool matchWord, | |||
| string source) | |||
| string source, | |||
| bool searchInALlRepos) | |||
There was a problem hiding this comment.
In addition to the other comment, this should be searchInAllRepos
| @@ -642,4 +642,7 @@ NOTE: Probably only necessary to change in RTL languages.</comment> | |||
| <data name="PackageView_Version" xml:space="preserve"> | |||
| <value>Version</value> | |||
| </data> | |||
| <data name="SettingsView_SearchInAllRepos" xml:space="preserve"> | |||
| <value>Search in all Repos</value> | |||
There was a problem hiding this comment.
Depending on the outcome of the above, we will likely want to change this text as well.
|
@mwallner I definitely prefer this being an opt-in option, so based on that, I have no objections. Can you have a look at the comments that I made, and also update to the latest develop branch? There are some changes that you will need to apply in the SettingsView to include a new description for the setting. Let me know if you have a chance to do this. Apologies in the time taken to get this reviewed. |
|
@gep13 @mwallner Instead of enabling this option globally I would like to see Probably there should be a way to hide |
|
@DamianMaslanka5 let me see if I have this right... You are suggesting that another "virtual" source be added, which combines the packages available from all the other sources, and then the search box is available to search this new source. Is that right? If I have understood you correctly, then the feature in settings would be to either enable, or disable, this new virtual source. I don't dislike this idea. @mwallner what are your thoughts? |
mwallner
force-pushed
the
searchallrepo
branch
from
fce474c
to
b200c1a
Compare
|
@DamianMaslanka5 - great idea! |
|
@gep13 @DamianMaslanka5 - see GH-646 |
|
Closing in favour of #646 |
see #588