Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Automapper to v7.0.1 #760

Merged
merged 1 commit into from
Apr 10, 2020
Merged

Update Automapper to v7.0.1 #760

merged 1 commit into from
Apr 10, 2020

Conversation

punker76
Copy link
Member

@punker76 punker76 commented Apr 10, 2020 •
edited
Loading

With this version I can fix an exception which I got at the ChocolateyService with the old one.

        private static Package GetMappedPackage(GetChocolatey choco, PackageResult package, IMapper mapper, bool forceInstalled = false)
        {
            var mappedPackage = package == null ? null : mapper.Map<Package>(package.Package);
            if (mappedPackage != null)

System.NullReferenceException
HResult=0x80004003
Message=Object reference not set to an instance of an object.

v7.0.1 is also the latest possible version for .Net v4.5.2

@punker76
Update Automapper to v7.0.1
676f167 
With this version I can fix an exception which I got with the old one.

System.NullReferenceException
  HResult=0x80004003
  Message=Object reference not set to an instance of an object.
@punker76 punker76 requested a review from gep13 April 10, 2020 19:54
gep13
gep13 approved these changes Apr 10, 2020
View reviewed changes
Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gep13 gep13 merged commit 140f9a5 into chocolatey:develop Apr 10, 2020
@gep13
Copy link
Member

gep13 commented Apr 10, 2020

@punker76 your changes have been merged, thanks for your contribution 👍

@punker76 punker76 deleted the feature/UpdateAutomapper branch April 10, 2020 20:09
@gep13 gep13 added this to the 0.18.0 milestone Apr 12, 2020
@gep13 gep13 added the Improvement Issues that enhances existing functionality, or adds new features label Apr 12, 2020
@choco-bot
Copy link

🎉 This issue has been resolved in version 0.18.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gep13 gep13 gep13 approved these changes

Assignees
No one assigned
Labels
Improvement Issues that enhances existing functionality, or adds new features
Projects
None yet
Milestone
0.18.0
Development

Successfully merging this pull request may close these issues.
3 participants
@punker76 @gep13 @choco-bot