Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install-BoxstarterPackage and boxtarter.bat not behaving the same #423

Closed
mkevenaar opened this issue Feb 23, 2020 · 2 comments · Fixed by #479
Closed

Install-BoxstarterPackage and boxtarter.bat not behaving the same #423

mkevenaar opened this issue Feb 23, 2020 · 2 comments · Fixed by #479
Assignees
Labels
5 - Released The issue has been resolved, and released to the public for consumption Bug Issues where something has happened which was not expected or intended
Milestone

Comments

@mkevenaar
Copy link

mkevenaar commented Feb 23, 2020

What You Are Seeing?

The result of running a boxstarter script with Install-BoxstarterPackage and boxstarter.bat to be inconsistent. A reboot is not triggered with Install-BoxstarterPackage, where boxstarter.bat does.

What Is Expected?

Both commands resulting in the same results.

How Did You Get This To Happen? (Steps to Reproduce)

  1. Create a boxstarter script with multiple reboots: (DotNet4.7.2 and veeam-explorer-for-microsoft-exchange-o365 require a reboot)
choco upgrade DotNet4.7.2
choco upgrade veeam-backup-for-microsoft-office-365 --params '"/server /powershell"'
choco upgrade veeam-backup-for-microsoft-office-365-console
choco upgrade veeam-explorer-for-microsoft-exchange-o365
choco upgrade veeam-explorer-for-microsoft-sharepoint-o365
choco upgrade veeam-backup-for-microsoft-office-365-management
  1. Execute this script with Install-BoxstarterPackage

Output Log

Packages requiring reboot:
 - veeam-explorer-for-microsoft-exchange-o365 (exit code 3010)
The recent package changes indicate a reboot is necessary.
 Please reboot at your earliest convenience.
Chocolatey reported an unsuccessful exit code of 3010. See C:\Users\vagrant\AppData\Local\Boxstarter\boxstarter.log for details.
+ Boxstarter finished Calling Chocolatey to install veeam-backup-for-microsoft-office-365-management. This may take several minutes to complete... 00:00:56.1124708
+ Boxstarter finished Calling Chocolatey to install veeam-backup-for-microsoft-office-365-management. This may take several minutes to complete... 00:00:56.1124708
Only an exit code of non-zero will fail the package by default. Set
 `--failonstderr` if you want error messages to also fail a script. See
 `choco -h` for details.
Environment Vars (like PATH) have changed. Close/reopen your shell to
 see the changes (or in powershell/cmd.exe just type `refreshenv`).
 The install of tmp335.tmp was successful.
  Software installed to 'C:\Program Files\Veeam\Backup and Replication\Explorers\SharePoint\'
Chocolatey installed 1/1 packages. 0 packages failed.
 See the log for details (C:\ProgramData\chocolatey\logs\chocolatey.log).
Chocolatey : Chocolatey reported an unsuccessful exit code of 3010. See C:\Users\vagrant\AppData\Local\Boxstarter\boxstarter.log for details.
At C:\ProgramData\Boxstarter\Boxstarter.Chocolatey\Invoke-ChocolateyBoxstarter.ps1:199 char:5
+     Chocolatey install $bootstrapPackage -source $source -force:$forc ...
+     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (:) [Write-Error], WriteErrorException
    + FullyQualifiedErrorId : Microsoft.PowerShell.Commands.WriteErrorException,chocolatey
++ Boxstarter finished Calling Chocolatey to install tmp335.tmp. This may take several minutes to complete... 00:01:49.7503565
@pauby pauby added 0 - _Triaging Issue is accepted, but a milestone has yet to be added for the issue Bug Issues where something has happened which was not expected or intended labels Feb 28, 2020
@pauby pauby assigned pauby and mwallner and unassigned pauby Feb 28, 2020
@mwallner mwallner added this to the 2.14.0 milestone Mar 4, 2020
@mwallner mwallner modified the milestones: 2.14.0, 3.0.0 Feb 16, 2022
@mwallner
Copy link
Member

Hi Maurice!
sorry for the long delay / it's been a while 😂

have you tried passing -Credential (Get-Credential) when using the Install-BoxstarterPackage cmdlet?
will try to create a repro, but afaik this should work (should trigger reboots when necessary).

@gep13 gep13 added 3 - Review Code has been added, and is available for review as a pull request and removed 0 - _Triaging Issue is accepted, but a milestone has yet to be added for the issue labels Apr 25, 2022
@gep13 gep13 added 4 - Done Code has been added to the repository, and has been reviewed by a team member and removed 3 - Review Code has been added, and is available for review as a pull request labels Apr 27, 2022
@gep13 gep13 modified the milestones: 3.0.0-beta-20220426-14, 3.0.0 Jul 14, 2022
@gep13 gep13 added 5 - Released The issue has been resolved, and released to the public for consumption and removed 4 - Done Code has been added to the repository, and has been reviewed by a team member labels Jul 14, 2022
@choco-bot
Copy link

🎉 This issue has been resolved in version 3.0.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Released The issue has been resolved, and released to the public for consumption Bug Issues where something has happened which was not expected or intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants