Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(GH-312) Add package verification for Chocolatey checks #329

Merged
merged 5 commits into from Jul 31, 2018
Merged

(GH-312) Add package verification for Chocolatey checks #329

merged 5 commits into from Jul 31, 2018

Conversation

pauby
Copy link
Member

@pauby pauby commented Jul 31, 2018

  • Adds the VERIFICATION.txt file to the build artifacts
  • Adds the VERIFICATION.txt file to the packages

@pauby pauby requested a review from gep13 July 31, 2018 12:50
@gep13 gep13 changed the title (#312) Add package verification for Chocolatey checks (GH-312) Add package verification for Chocolatey checks Jul 31, 2018
Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the numbers in the verification.txt file.


1. Please go to the project source location (https://github.com/chocolatey/boxstarter);
2. Download the source files for the module you want to verify. Make sure the version of the file you download is the same version as the files from the package you want to verify;
2. For each source file use Get-FileHash -Path <FILE TO VERIFY> to get the file hash value from both the downloaded file (from step 1 above) and the file from the package and compare them;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1, 2, 3...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gep13 gep13 merged commit ad6936c into chocolatey:master Jul 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants