Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatic Uninstaller Should Skip When Uninstaller executable does not exist #1035

Closed
ferventcoder opened this issue Nov 1, 2016 · 0 comments
Closed

Automatic Uninstaller Should Skip When Uninstaller executable does not exist #1035

ferventcoder opened this issue Nov 1, 2016 · 0 comments
Assignees
@ferventcoder
Labels
5 - Released Bug Priority_HIGH
Milestone
0.10.4

Comments

@ferventcoder
Copy link
Member

ferventcoder commented Nov 1, 2016 •
edited

tl;dr: The autouninstaller should see if the uninstaller executable still exists prior to attempting to run it.

Original title: Automatic Uninstaller Fails To Determine Software Uninstalled if it Doesn't Remove the Uninstaller Key

The uninstaller for openvpn doesn't handle the removal of the uninstall registry key, nor does it remove the folder. This makes it a bad uninstaller, but Chocolatey should better be able to handle that.

This makes Chocolatey's auto uninstaller service think it needs to attempt an uninstall because the registry key and the folder for the software still exist. But when it attempts to run the uninstaller, it fails because the uninstaller file no longer exists.

Reference:
@ferventcoder ferventcoder added this to the 0.10.4 milestone Nov 1, 2016
@ferventcoder ferventcoder self-assigned this Nov 1, 2016
@ferventcoder ferventcoder changed the title Automatic Uninstaller Fails To Determine Software Uninstalled if it Doesn't Remove the Uninstaller Key Automatic Uninstaller Should Skip When Uninstaller executable does not exist Nov 1, 2016
@ferventcoder ferventcoder mentioned this issue Nov 4, 2016
Merged
@MartyGentillon MartyGentillon mentioned this issue Nov 26, 2016
Merged
MartyGentillon added a commit to MartyGentillon/chocolateypackages that referenced this issue Nov 26, 2016
@MartyGentillon
Fix for race condition bug in Chocolaty 0.10.3
a7e5057 
In 0.10.3, the Chocolaty auto uninstaller is attempting to uninstall the package even though
it has already been uninstalled.  This occurs when it the auto-uninstaller fails to find the
recently removed installer.  This change adds a short wait to chocolateyUninstall.ps1 to
allow time for the changes to propagate in the registry.

This bug is fixed in Chocolaty 0.10.4, where it will no longer fail when the uninstaller is
not found

see:
chocolatey/choco#1035
MartyGentillon added a commit to MartyGentillon/chocolateypackages that referenced this issue Nov 26, 2016
@MartyGentillon
Fix for race condition bug in Chocolaty 0.10.3 on community edition.
96886d6 
In 0.10.3, the Chocolaty auto uninstaller is attempting to uninstall the package even though
it has already been uninstalled.  This occurs when it the auto-uninstaller fails to find the
recently removed installer.  This change adds a short wait to chocolateyUninstall.ps1 to
allow time for the changes to propagate in the registry.

This bug is fixed in Chocolaty 0.10.4, where it will no longer fail when the uninstaller is
not found

see:
chocolatey/choco#1035
ferventcoder added a commit to ferventcoder/choco that referenced this issue Jan 4, 2017
@ferventcoder
(chocolateyGH-1035) Auto Uninstaller Skip if File Doesn't Exist
afcabae 
If the uninstaller executable does not exist, then skip running auto
uninstaller. Without this change, choco would attempt to run the
uninstaller and fail. With this in place, Automatic Uninstaller will
simply skip the attempt to run when the file no longer exists.
ferventcoder added a commit that referenced this issue Jan 4, 2017
@ferventcoder
Merge branch 'stable'
6031bb8 
* stable:
  (GH-1117) Get-ChocolateyWebFile - Url Overrides
  (maint) Do not error on missing SMA dll resources
  (GH-1126) Start-ChocolateyProcess no elevate when admin
  (GH-1013) PowerShell external - set debug/verbose false
  (maint) Fix: PackageResult Errors if DownloadUrl is Null
  (maint) formatting
  (GH-1121) API - Do not reset loggers
  (GH-1041) Fix: Skip loading synced dlls as extensions
  (GH-1013) PowerShell - Only import installer module
  (GH-1118) Feature to disable non-elevated warnings
  (maint)(log) Show Formatted Download Progress Only
  (GH-1035) Auto Uninstaller Skip if File Doesn't Exist
  (GH-1119) Auto Uninstaller - Allow remove directly
  (build) change message
  (doc) explain upgrading licensed version
Apteryx0 pushed a commit to Apteryx0/choco that referenced this issue Jan 23, 2017
@ferventcoder
(chocolateyGH-1035) Auto Uninstaller Skip if File Doesn't Exist
a9381a8 
If the uninstaller executable does not exist, then skip running auto
uninstaller. Without this change, choco would attempt to run the
uninstaller and fail. With this in place, Automatic Uninstaller will
simply skip the attempt to run when the file no longer exists.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ferventcoder ferventcoder

Labels
5 - Released Bug Priority_HIGH
Projects
None yet
Milestone
0.10.4
Development

No branches or pull requests
2 participants
@ferventcoder @gep13