Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not create .ignore file if outside of Chocolatey location #1180

Closed
ferventcoder opened this issue Mar 3, 2017 · 0 comments
Closed

Do not create .ignore file if outside of Chocolatey location #1180

ferventcoder opened this issue Mar 3, 2017 · 0 comments
Assignees
@ferventcoder
Labels
5 - Released Customer Improvement
Milestone
0.10.4

Comments

@ferventcoder
Copy link
Member

No description provided.

@ferventcoder ferventcoder self-assigned this Mar 3, 2017
@ferventcoder ferventcoder added this to the 0.10.4 milestone Mar 3, 2017
ferventcoder added a commit that referenced this issue Mar 3, 2017
@ferventcoder
(GH-1180) Create .ignore file only in choco path
ff77cfd 
If Chocolatey is installing a binary outside of the Chocolatey
directories, there is no need to have it attempt to create a `.ignore`
file. Sometimes that generates a warning that is not helpful and may be
confused for other issues that are real.
ferventcoder added a commit to ferventcoder/choco that referenced this issue Mar 9, 2017
@ferventcoder
Merge branch 'stable'
81b6797 
* stable:
  (chocolateyGH-1193) Allow version check with FIPS
  (chocolateyGH-1155) do not warn nupkg on pack/push
  (chocolateyGH-1187) File64 - Install-ChocolateyInstallPackage
  (maint) Add 64-bit process Information variable
  (chocolateyGH-1155) Warn when .nupkg/.nuspec used in args
  (chocolateyGH-262) BypassProxy on IHttpClient
  (chocolateyGH-1134) use console adapter for width
  (chocolateyGH-1182) trace network traffic
  (chocolateyGH-1181) Configure a source for self-service
  (chocolateyGH-1180) Create .ignore file only in choco path
  (chocolateyGH-1177) Fix: MSU fails when spaces in path
  (maint) formatting
  (chocolateyGH-1178) Fix: OS_NAME not reported as Windows 10
  (chocolateyGH-1134) ensure GetPackageManager w/older licensed
  (chocolateyGH-1165) pass proxy bypass list to debug message
ferventcoder added a commit that referenced this issue Mar 28, 2017
@ferventcoder
(GH-1180) Ensure values are escaped for regex
feb0829 
When looking to see if the ignore file is a match for being in the
Chocolatey Install directories, ensure you escape the ChocolateyInstall
environment variable, which will have backslashes in it. This removes
any issues like `ERROR: parsing "C:\ProgramData\chocolatey" - Malformed
\p{X} character escape`.
ferventcoder added a commit that referenced this issue Mar 28, 2017
@ferventcoder
Merge branch 'stable'
bceb868 
* stable:
  (GH-1210) CacheLocation - Prevent nested chocolatey directories
  (GH-1209) Add Chocolatey Software to copyright
  (GH-1180) Ensure values are escaped for regex
  (maint) note about removing section
  (GH-797) Conditionally remember execution timeout
  (GH-1208) auto uninstaller - split by quotes
  (maint) formatting
  (GH-797) Use remembered arguments when upgrading
  (GH-797) Encrypt & remember certain arguments
  (GH-797) OptionSet available globally
  (GH-797) Move check for sensitive data to function
  (maint) update tab expansion for 0.10.4 & licensed
  (GH-797) Add remembered arguments parameters
  (doc) update CHANGELOG/nuspec
  (docs) update licensed changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ferventcoder ferventcoder

Labels
5 - Released Customer Improvement
Projects
None yet
Milestone
0.10.4
Development

No branches or pull requests
2 participants
@ferventcoder @gep13