Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API] Ensure DLL can work with licensed code #1287

Closed
ferventcoder opened this issue May 8, 2017 · 0 comments
Closed

[API] Ensure DLL can work with licensed code #1287

ferventcoder opened this issue May 8, 2017 · 0 comments

Comments

@ferventcoder
Copy link
Member

When working to determine the issue with the licensed code, a couple of incompatibilities between choco.exe and chocolatey.dll were found that were preventing Chocolatey from allowing the licensed edition to work with the DLL.

@ferventcoder ferventcoder added this to the 0.10.6 milestone May 8, 2017
@ferventcoder ferventcoder self-assigned this May 8, 2017
@ferventcoder ferventcoder changed the title API - Ensure DLL can work with licensed code [API] Ensure DLL can work with licensed code May 14, 2017
ferventcoder added a commit that referenced this issue May 18, 2017
When working to determine the issue with the licensed code, a couple of
incompatibilities between choco.exe and chocolatey.dll were found that
were preventing Chocolatey from allowing the licensed edition to work
with the DLL.

Specifically, `System.Reflection.TargetInvocationException
System.MethodAccessException: Attempt by method to access method
failed` as methods for checking some things were missing (internalized)
in the DLL, where they were available in the EXE. Adjust to allow
for those items to be loaded.
ferventcoder added a commit that referenced this issue May 18, 2017
SimpleInjector is no longer internalized, so that can cause an
ambiguous conflict when adding the Chocolatey library to a codebase.
Add XML comments in the API to note this for all methods that call into
the container.
ferventcoder added a commit to ferventcoder/choco that referenced this issue May 18, 2017
* stable:
  Remove duplicate word
  (chocolateyGH-1285) Default push to new or old w/warning
  (chocolateyGH-1285) Add old/new default push source
  (chocolateyGH-1298) GenericRunner.count() sets security protocol
  (chocolateyGH-1298) GenericRunner.list() should match run()
  (maint) API - Warn on extraction errors
  (chocolateyGH-389) API - Ensure ChocolateyInstall env var
  (maint) Do not load config back into global
  (chocolateyGH-1296) API - Reuse existing base configuration
  (maint) API - Note methods that won't allow changes
  (chocolateyGH-1294) API - Expose container directly
  (build) option to build debug version
  (doc) Source/Key notes surrounding source/apikey
  (maint) log that license file has been found
  (chocolateyGH-1287) Non-internal SimpleInjector XML Comments
  (maint) formatting
  (chocolateyGH-1287) API - Ensure dll can work w/licensed code
  (chocolateyGH-1284) Install-ChocolateyPackage aliases File/File64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants