Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API] Ensure configuration retains base info between uses #1296

Closed
ferventcoder opened this issue May 15, 2017 · 0 comments
Closed

[API] Ensure configuration retains base info between uses #1296

ferventcoder opened this issue May 15, 2017 · 0 comments
Assignees
@ferventcoder
Labels
5 - Released API Improvement Priority_HIGH Pro/Business
Milestone
0.10.6

Comments

@ferventcoder
Copy link
Member

ferventcoder commented May 15, 2017 •
edited

Every time the configuration is called for in the API it returns a new ChocolateyConfiguration object. However this will not work with licensed editions of Chocolatey, as they load some base information into that configuration and need to ensure that they can load that base configuration each time and licensed functionality.

Ensure instead that the configuration gets reset to the base each time it is used and doesn't lose that base information.
@ferventcoder ferventcoder added this to the 0.10.6 milestone May 15, 2017
@ferventcoder ferventcoder self-assigned this May 15, 2017
@ferventcoder ferventcoder changed the title [API] Ensure configuration is reset between uses [API] Ensure configuration retains base info between uses May 15, 2017
ferventcoder added a commit that referenced this issue May 18, 2017
@ferventcoder
(GH-1296) API - Reuse existing base configuration
5ace6fd 
Previously, every time the configuration was called for in the API it
would return a new `ChocolateyConfiguration` object. However this
would not work with licensed editions of Chocolatey, as they load some
base information into that configuration and need to ensure that they
can load that base configuration each time and licensed functionality.

Ensure instead that the configuration gets reset to the base each time
it is used and doesn't lose that base information.
ferventcoder added a commit to ferventcoder/choco that referenced this issue May 18, 2017
@ferventcoder
Merge branch 'stable'
52837e2 
* stable:
  Remove duplicate word
  (chocolateyGH-1285) Default push to new or old w/warning
  (chocolateyGH-1285) Add old/new default push source
  (chocolateyGH-1298) GenericRunner.count() sets security protocol
  (chocolateyGH-1298) GenericRunner.list() should match run()
  (maint) API - Warn on extraction errors
  (chocolateyGH-389) API - Ensure ChocolateyInstall env var
  (maint) Do not load config back into global
  (chocolateyGH-1296) API - Reuse existing base configuration
  (maint) API - Note methods that won't allow changes
  (chocolateyGH-1294) API - Expose container directly
  (build) option to build debug version
  (doc) Source/Key notes surrounding source/apikey
  (maint) log that license file has been found
  (chocolateyGH-1287) Non-internal SimpleInjector XML Comments
  (maint) formatting
  (chocolateyGH-1287) API - Ensure dll can work w/licensed code
  (chocolateyGH-1284) Install-ChocolateyPackage aliases File/File64
@ferventcoder ferventcoder mentioned this issue Jun 22, 2017
Closed
This was referenced Aug 29, 2017
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ferventcoder ferventcoder

Labels
5 - Released API Improvement Priority_HIGH Pro/Business
Projects
None yet
Milestone
0.10.6
Development

No branches or pull requests
2 participants
@ferventcoder @gep13