New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API] Expose Package Results through the API #132

Closed

ferventcoder opened this issue Feb 28, 2015 · 3 comments

Assignees

Labels

5 - Released API Improvement

Milestone

Member

ferventcoder commented Feb 28, 2015

No description provided.

ferventcoder added the 0 - Backlog label

ferventcoder added this to the 0.9.10 milestone

ferventcoder added the Improvement label

Contributor

Jaykul commented Mar 1, 2015

Do you want to change or overload the "Run()" method so it can return output?
Maybe a generic List<T> Run<T>() overload?

I mean this is going to need to include most of the commands where the user expects to see output, at least:
list, search, source list, ...

Member Author

ferventcoder commented Mar 1, 2015

Actually it's more about adding other methods like List, Install, etc instead of just Run(). Run is fire and forget.

Jaykul added a commit to Jaykul/choco that referenced this issue


          (chocolateyGH-132) Add ChocolateySource class distinct from serialize…

81dd438

…d source

Jaykul added a commit to Jaykul/choco that referenced this issue


          (chocolateyGH-132) Change source_list to return a list of sources

333e6e7

Jaykul added a commit to Jaykul/choco that referenced this issue


          (chocolateyGH-132) Change ChocolateySourceCommand to an IListCommand

a61a38b

In order to make commands support listing, add a new command interface
 the IListCommand interface is an ICommand with an extra method "list"

Jaykul added a commit to Jaykul/choco that referenced this issue


          (chocolateyGH-132) Add a list method to the GenericRunner

90eb8d8

Refactor GenericRunner.run to a common find_command and separate the
 run and list methods which call different methods on the underlying
 command (IListCommand).

Previously we only supported GenericRunner.run, this also updates
 GetChocolatey to add a list method that calls GenericRunner.list

Jaykul added a commit to Jaykul/choco that referenced this issue


          (chocolateyGH-132) Add ChocolateySource class distinct from serialize…

f923caf

…d source

Jaykul added a commit to Jaykul/choco that referenced this issue


          (chocolateyGH-132) Change source_list to return a list of sources

a7ccc86

Jaykul added a commit to Jaykul/choco that referenced this issue


          (chocolateyGH-132) Change ChocolateySourceCommand to an IListCommand

f479a83

In order to make commands support listing, add a new command interface
 the IListCommand interface is an ICommand with an extra method "list"

Jaykul added a commit to Jaykul/choco that referenced this issue


          (chocolateyGH-132) Add a list method to the GenericRunner

c4b7e7b

Refactor GenericRunner.run to a common find_command and separate the
 run and list methods which call different methods on the underlying
 command (IListCommand).

Previously we only supported GenericRunner.run, this also updates
 GetChocolatey to add a list method that calls GenericRunner.list

Jaykul added a commit to Jaykul/choco that referenced this issue


          (chocolateyGH-132) Add ChocolateySource class distinct from serialize…

8702e01

…d source

Jaykul added a commit to Jaykul/choco that referenced this issue


          (chocolateyGH-132) Change source_list to return a list of sources

8364b0e

Jaykul added a commit to Jaykul/choco that referenced this issue


          (chocolateyGH-132) Change ChocolateySourceCommand to an IListCommand

cec6145

In order to make commands support listing, add a new command interface
 the IListCommand interface is an ICommand with an extra method "list"

Jaykul added a commit to Jaykul/choco that referenced this issue


          (chocolateyGH-132) Add a list method to the GenericRunner

80a84e4

Refactor GenericRunner.run to a common find_command and separate the
 run and list methods which call different methods on the underlying
 command (IListCommand).

Previously we only supported GenericRunner.run, this also updates
 GetChocolatey to add a list method that calls GenericRunner.list

ferventcoder added a commit that referenced this issue


          Merge pull request #137 from Jaykul/master

1d8448c

Start exposing lists and package results via the API #132

gep13 pushed a commit to gep13/choco that referenced this issue


          (chocolateyGH-132) Add ChocolateySource class distinct from serialize…

a7358f5

…d source

gep13 pushed a commit to gep13/choco that referenced this issue


          (chocolateyGH-132) Change source_list to return a list of sources

4ec6c13

gep13 pushed a commit to gep13/choco that referenced this issue


          (chocolateyGH-132) Change ChocolateySourceCommand to an IListCommand

1e322cd

In order to make commands support listing, add a new command interface
 the IListCommand interface is an ICommand with an extra method "list"

gep13 pushed a commit to gep13/choco that referenced this issue


          (chocolateyGH-132) Add a list method to the GenericRunner

f6a6c15

Refactor GenericRunner.run to a common find_command and separate the
 run and list methods which call different methods on the underlying
 command (IListCommand).

Previously we only supported GenericRunner.run, this also updates
 GetChocolatey to add a list method that calls GenericRunner.list

gep13 pushed a commit to gep13/choco that referenced this issue


          (chocolateyGH-132) Add ChocolateySource class distinct from serialize…

3b61721

…d source

gep13 pushed a commit to gep13/choco that referenced this issue


          (chocolateyGH-132) Change source_list to return a list of sources

2cd6f1b

gep13 pushed a commit to gep13/choco that referenced this issue


          (chocolateyGH-132) Change ChocolateySourceCommand to an IListCommand

bb9f00b

In order to make commands support listing, add a new command interface
 the IListCommand interface is an ICommand with an extra method "list"

gep13 pushed a commit to gep13/choco that referenced this issue


          (chocolateyGH-132) Add a list method to the GenericRunner

431436a

Refactor GenericRunner.run to a common find_command and separate the
 run and list methods which call different methods on the underlying
 command (IListCommand).

Previously we only supported GenericRunner.run, this also updates
 GetChocolatey to add a list method that calls GenericRunner.list

gep13 pushed a commit to gep13/choco that referenced this issue


          (chocolateyGH-132) Add ChocolateySource class distinct from serialize…

6702c39

…d source

gep13 pushed a commit to gep13/choco that referenced this issue


          (chocolateyGH-132) Change source_list to return a list of sources

1ec5af7

gep13 pushed a commit to gep13/choco that referenced this issue


          (chocolateyGH-132) Change ChocolateySourceCommand to an IListCommand

In order to make commands support listing, add a new command interface
 the IListCommand interface is an ICommand with an extra method "list"

gep13 pushed a commit to gep13/choco that referenced this issue


          (chocolateyGH-132) Add a list method to the GenericRunner

7ded8f3

Refactor GenericRunner.run to a common find_command and separate the
 run and list methods which call different methods on the underlying
 command (IListCommand).

Previously we only supported GenericRunner.run, this also updates
 GetChocolatey to add a list method that calls GenericRunner.list

Jaykul added a commit to Jaykul/choco that referenced this issue


          (chocolateyGH-132) Make InstallCommand and UninstallCommand output re…

3a08570

…sults for API purposes

Jaykul added a commit to Jaykul/choco that referenced this issue


          (chocolateyGH-132) Make InstallCommand and UninstallCommand output re…

98ff179

…sults for API purposes

Jaykul mentioned this issue

(GH-132) List command #225

Closed

Jaykul added a commit to Jaykul/choco that referenced this issue


          (chocolateyGH-132) Make InstallCommand and UninstallCommand output re…

b6c91b2

…sults for API purposes

ferventcoder modified the milestones: 0.9.9.9, 0.9.10

ferventcoder pushed a commit that referenced this issue


          (GH-132) PackageService / ListCommand List for API

ff4a1f0

Ensure that PackageService and List command are able to list output for API
purposes.

ferventcoder pushed a commit that referenced this issue


          (GH-132) Use Config.QuietOutput for List commands

5782a21

ferventcoder added a commit that referenced this issue


          Merge branch 'ListCommand' into stable

3c12763

* ListCommand:
  (GH-223) Fix handling of LocalOnly for API
  (GH-132) Use Config.QuietOutput for List commands
  (GH-132) PackageService / ListCommand List for API

ferventcoder added a commit that referenced this issue


          Merge branch 'stable'

909ab18

* stable:
  (GH-223) Fix handling of LocalOnly for API
  (GH-132) Use Config.QuietOutput for List commands
  (GH-132) PackageService / ListCommand List for API

Conflicts:
	src/chocolatey/infrastructure.app/commands/ChocolateyListCommand.cs
	src/chocolatey/infrastructure.app/services/ChocolateyPackageService.cs
	src/chocolatey/infrastructure.app/services/INugetService.cs
	src/chocolatey/infrastructure.app/services/NugetService.cs
	src/chocolatey/infrastructure/commands/IListCommand.cs

ferventcoder closed this as completed

ferventcoder added 4 - Done and removed 0 - Backlog labels

ferventcoder self-assigned this

ferventcoder added the API label

Member Author

ferventcoder commented Oct 3, 2015

Unfortunately this one just broke almost every configuration manager that uses choco - 5782a21#commitcomment-13577152

crt mentioned this issue

List output for other tools messed up in 0.9.9.9 (pipe separator missing) #450

Closed

aronovgj mentioned this issue

choco pin list is broken #452

Closed

ferventcoder added a commit that referenced this issue


          (GH-452) Fix broken pin command

Choco pin list used to ensure that the output from the local `list_run`
command did not output on stdout. However a commit in GH-132 caused pin
to start outputting the list output as well as pin output. Fix this by
adding `config.QuietOutput = true;` around the call to List_run.

Also add integration spec scenarios to ensure this is not subject to
happen again.

ferventcoder added a commit that referenced this issue


          (GH-604) Source Operations Should Respect Quiet

978fab9

Any operations on sources should respect Quiet. This also corrects a
bug that was introduced by GH-132 in
8364b0e that removed output
information that is needed for tools that use choco. That has never
been introduced as a released version, so thankfully the bug doesn't
need to be worked around in any tools.

ferventcoder changed the title ~~Expose Package Results through the API~~ [API] Expose Package Results through the API

gep13 added 5 - Released and removed 4 - Done labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment