Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to use authorization headers in the Get-WebFile function #1998

Closed
steviecoaster opened this issue Feb 6, 2020 · 3 comments
Closed

Add ability to use authorization headers in the Get-WebFile function #1998

steviecoaster opened this issue Feb 6, 2020 · 3 comments
Assignees
@steviecoaster
Labels
5 - Released Improvement
Milestone
0.11.0

Comments

@steviecoaster
Copy link
Contributor

Passing authorization headers through Install-ChocolateyPackage does not attach them to Get-WebFile downstream properly.
@steviecoaster steviecoaster mentioned this issue Feb 6, 2020
Closed
@eocern
Copy link

eocern commented Jun 26, 2020

Hi there busy bees :-) I am hitting that issue now. Any chance you can check on the failed PR build due to a package dependency issue ?

@gep13 gep13 added this to the 0.10.16 milestone Apr 18, 2021
gep13 pushed a commit that referenced this issue Apr 18, 2021
@steviecoaster @gep13
(#1998) Add authorization header to Get-WebFile
5580558 
Passing authorization headers through Install-ChocolateyPackage does not
attach them to Get-WebFile downstream properly.

Reworks headers to not use GetEnumerator() method, and appropriately
adds headers to `$options` hashtable.
gep13 added a commit that referenced this issue Apr 18, 2021
@gep13
Merge branch 'GH-1998' into stable
e6c42ba 
* GH-1998:
  (#1998) Add authorization header to Get-WebFile
@gep13
Copy link
Member

gep13 commented Apr 18, 2021

@eocern this has been merged in, and will go out with the next release.

@gep13 gep13 closed this as completed Apr 18, 2021
gep13 added a commit that referenced this issue Apr 19, 2021
@gep13
Merge branch 'stable' into master
5868c66 
* stable:
  (#1861) Improves terminology in help documentation
  (#1998) Add authorization header to Get-WebFile
  (maint) Repalce RawGit with raw.githack.com CDN
  (#1899) Remove unused variables
  (GH-1060) Add BeforeInstall parameter to Install-ChocolateyPackage.ps1
  (maint) Improve log message
  (GH-2092) Take all registry keys into account
  (GH-1364) Template create .nuspec encoded without BOM
  (#1866) Limit pending package removal to top level
  (GH-2203) Get-ChocolateyUnzip add unzipLocation alias
  (GH-1889) Fix: Removal of ApiKey broken
  (#2114) Remove unused variable
  (GH-2048) update deprecation note to outdated
  (maint) Spelling and grammar fixes
  (maint) Replace tabs with spaces
  (#2078) Skip importing Chocolatey GUI Extension
  (#2227) Use latest Mono and Ubuntu on Travis
steviecoaster added a commit to steviecoaster/choco that referenced this issue May 11, 2021
@steviecoaster
Merge branch 'GH2112' of https://github.com/steviecoaster/choco into …
61102d6 
…GH2112

* 'GH2112' of https://github.com/steviecoaster/choco:
  (chocolatey#2112) Add msp support to Install helper
  (maint) Switch to using a Regex match
  (maint) Change formatting
  (maint) Remove use of PowerShell aliases
  (maint) Replace " with '
  (chocolatey#2044) Fix for changing $env:Temp
  (chocolatey#2259) Switched to versioned NuGet.Core
  (chocolatey#2111) Deep copy config
  (chocolatey#2244) Add Mac build into main workflow
  (chocolatey#2238) Mono build don't hardcode xbuild path
  (maint) Fix artifact paths on AppVeyor
  (chocolatey#2244) Fix syntax for running on Windows
  (chocolatey#2244) Initial workflow for Windows and Ubuntu
  (doc) Remove Mono instructions for other distributions
  (doc) Add Ubuntu 20.04 mono install instructions
  (chocolatey#2227) Bump Mono version in Dockerfile and README
  (chocolatey#2236) Mono test work with merged usr systems
  (chocolatey#2190) Clarify help for SpecificFolder parameter
  (chocolatey#1962) Use different message on error
  (chocolatey#1861) Improves terminology in help documentation
  (chocolatey#1998) Add authorization header to Get-WebFile
  (maint) Repalce RawGit with raw.githack.com CDN
  (chocolatey#1899) Remove unused variables
  (chocolateyGH-1060) Add BeforeInstall parameter to Install-ChocolateyPackage.ps1
  (maint) Improve log message
  (chocolateyGH-2092) Take all registry keys into account
  (chocolateyGH-1364) Template create .nuspec encoded without BOM
  (chocolatey#1866) Limit pending package removal to top level
  (chocolateyGH-2203) Get-ChocolateyUnzip add unzipLocation alias
  (chocolateyGH-1889) Fix: Removal of ApiKey broken
  (chocolatey#2114) Remove unused variable
  (chocolateyGH-2048) update deprecation note to outdated
  (maint) Spelling and grammar fixes
  (maint) Replace tabs with spaces
  (chocolatey#2078) Skip importing Chocolatey GUI Extension
  (chocolatey#2227) Use latest Mono and Ubuntu on Travis
  (chocolatey#2205) Remove mention of private repository
  (chocolatey#2205) Update remaining URLs to new location
  (maint) Remove unnecessary whitespace
  (chocolatey#2231) Change default repository URL
  (maint) Remove unnecessary whitespace
  (chocolatey#2205) Update all chocolatey.org/docs URLs
  (maint) Remove unnecessary whitespace
  (chocolatey#2205) Update automatic-packages docs links
  (doc) Update to prefer # rather than GH-
  (maint) Fix replacement
  (maint) Revert change to earlier commit
  (maint) Fix spelling mistake
  (maint) Fix spelling mistake
  (doc) Update script to Statiq format
  (maint) Add missing backtick in example
  (maint) Added explicit link to new function name
  (maint) Fix spelling mistake
  (maint) Fix spelling mistake
  (maint) Fix spelling mistake
  (maint) Fix spelling mistake
  (maint) Fix spelling mistake
  (maint) Fix spelling mistake
  (maint) Remove generated docs files
  (maint) Add docs/generated folder to ignore list
  (chocolateyGH-2105) Update link to Chocolatey workshop
@gep13 gep13 changed the title Get-WebFile does not handle authorization headers Add ability to use authorization headers in the Get-WebFile function May 18, 2021
@gep13 gep13 mentioned this issue Sep 21, 2021
Closed
@gep13
Copy link
Member

gep13 commented Sep 21, 2021

@steviecoaster @eocern I have just been back to fully test this, and it looks like this was working correctly within 0.10.15, before the change was made in 0.11.0 to attempt to add the Authorization header to the HttpWebRequest.

As you will see in this screenshot:

2021-09-21_13-51-33

The four headers, Accept, Cookie, Referer, and Authorization all make their way into the request that Chocolatey emits when fetching the file.

The change that was introduced in 0.11.0 actually introduces a bug, which I am planning on backing out, and shipping a new v0.11.2 of Chocolatey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@steviecoaster steviecoaster

Labels
5 - Released Improvement
Projects
None yet
Milestone
0.11.0
Development

Successfully merging a pull request may close this issue.

(#1998) Add authorization header to Get-WebFile
3 participants
@gep13 @steviecoaster @eocern