Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused variable in uninstall template generated from choco new command #2114

Closed
DdOtzen opened this issue Sep 10, 2020 · 2 comments
Closed

Remove unused variable in uninstall template generated from choco new command #2114

DdOtzen opened this issue Sep 10, 2020 · 2 comments
Labels
5 - Released Improvement Priority_LOW
Milestone
0.11.0

Comments

@DdOtzen
Copy link
Contributor

DdOtzen commented Sep 10, 2020

What You Are Seeing?

An unused variable, with no obvious purpose.

What is Expected?

Nu unused variable, or a comment telling me the purpose of having it there.

How Did You Get This To Happen? (Steps to Reproduce)

choco new test
open tools\chocolateyuninstall.ps1 in editor

Output Log

Output of new command In here you see choco version 

choco new test
Chocolatey v0.10.15
Creating a new package specification at C:\dock\choco_test\test
Generating template to a file
 at 'C:\dock\choco_test\test\test.nuspec'
Generating template to a file
 at 'C:\dock\choco_test\test\tools\chocolateyinstall.ps1'
Generating template to a file
 at 'C:\dock\choco_test\test\tools\chocolateybeforemodify.ps1'
Generating template to a file
 at 'C:\dock\choco_test\test\tools\chocolateyuninstall.ps1'
Generating template to a file
 at 'C:\dock\choco_test\test\tools\LICENSE.txt'
Generating template to a file
 at 'C:\dock\choco_test\test\tools\VERIFICATION.txt'
Generating template to a file
 at 'C:\dock\choco_test\test\ReadMe.md'
Generating template to a file
 at 'C:\dock\choco_test\test\_TODO.txt'
Successfully generated test package specification files
 at 'C:\dock\choco_test\test'

### Suggested fix https://github.com/DdOtzen/choco/commit/4a27313a5f16053b8deb5e5ed0bd944dbe47353f#diff-28d68910eb8b4dca570c58ee95dc733e
@DdOtzen DdOtzen changed the title unused variable in chocolateyuninstall.ps1 unused variable in chocolateyuninstall.ps1 template Sep 10, 2020
@ferventcoder
Copy link
Member

This was removed in commit 804458c. Had to research that one. If you have a PR, target stable and we can get that in pretty quickly. Thanks in advance!

@ferventcoder ferventcoder added this to the 0.10.16 milestone Sep 10, 2020
@DdOtzen DdOtzen mentioned this issue Sep 11, 2020
Closed
@DdOtzen
Copy link
Contributor Author

DdOtzen commented Sep 11, 2020

Created PR #2117

gep13 pushed a commit that referenced this issue Apr 16, 2021
@DdOtzen @gep13
(#2114) Remove unused variable
fe95f1c 
As discussed in #2114 (comment)
gep13 added a commit that referenced this issue Apr 16, 2021
@gep13
Merge branch 'pr2117' into stable
4656042 
* pr2117:
  (#2114) Remove unused variable
@gep13 gep13 linked a pull request Apr 16, 2021 that will close this issue
Remove unused variable #2117
Closed
@gep13 gep13 closed this as completed Apr 16, 2021
@gep13 gep13 changed the title unused variable in chocolateyuninstall.ps1 template Remove unused variable in uninstall template Apr 16, 2021
gep13 added a commit that referenced this issue Apr 19, 2021
@gep13
Merge branch 'stable' into master
5868c66 
* stable:
  (#1861) Improves terminology in help documentation
  (#1998) Add authorization header to Get-WebFile
  (maint) Repalce RawGit with raw.githack.com CDN
  (#1899) Remove unused variables
  (GH-1060) Add BeforeInstall parameter to Install-ChocolateyPackage.ps1
  (maint) Improve log message
  (GH-2092) Take all registry keys into account
  (GH-1364) Template create .nuspec encoded without BOM
  (#1866) Limit pending package removal to top level
  (GH-2203) Get-ChocolateyUnzip add unzipLocation alias
  (GH-1889) Fix: Removal of ApiKey broken
  (#2114) Remove unused variable
  (GH-2048) update deprecation note to outdated
  (maint) Spelling and grammar fixes
  (maint) Replace tabs with spaces
  (#2078) Skip importing Chocolatey GUI Extension
  (#2227) Use latest Mono and Ubuntu on Travis
steviecoaster added a commit to steviecoaster/choco that referenced this issue May 11, 2021
@steviecoaster
Merge branch 'GH2112' of https://github.com/steviecoaster/choco into …
61102d6 
…GH2112

* 'GH2112' of https://github.com/steviecoaster/choco:
  (chocolatey#2112) Add msp support to Install helper
  (maint) Switch to using a Regex match
  (maint) Change formatting
  (maint) Remove use of PowerShell aliases
  (maint) Replace " with '
  (chocolatey#2044) Fix for changing $env:Temp
  (chocolatey#2259) Switched to versioned NuGet.Core
  (chocolatey#2111) Deep copy config
  (chocolatey#2244) Add Mac build into main workflow
  (chocolatey#2238) Mono build don't hardcode xbuild path
  (maint) Fix artifact paths on AppVeyor
  (chocolatey#2244) Fix syntax for running on Windows
  (chocolatey#2244) Initial workflow for Windows and Ubuntu
  (doc) Remove Mono instructions for other distributions
  (doc) Add Ubuntu 20.04 mono install instructions
  (chocolatey#2227) Bump Mono version in Dockerfile and README
  (chocolatey#2236) Mono test work with merged usr systems
  (chocolatey#2190) Clarify help for SpecificFolder parameter
  (chocolatey#1962) Use different message on error
  (chocolatey#1861) Improves terminology in help documentation
  (chocolatey#1998) Add authorization header to Get-WebFile
  (maint) Repalce RawGit with raw.githack.com CDN
  (chocolatey#1899) Remove unused variables
  (chocolateyGH-1060) Add BeforeInstall parameter to Install-ChocolateyPackage.ps1
  (maint) Improve log message
  (chocolateyGH-2092) Take all registry keys into account
  (chocolateyGH-1364) Template create .nuspec encoded without BOM
  (chocolatey#1866) Limit pending package removal to top level
  (chocolateyGH-2203) Get-ChocolateyUnzip add unzipLocation alias
  (chocolateyGH-1889) Fix: Removal of ApiKey broken
  (chocolatey#2114) Remove unused variable
  (chocolateyGH-2048) update deprecation note to outdated
  (maint) Spelling and grammar fixes
  (maint) Replace tabs with spaces
  (chocolatey#2078) Skip importing Chocolatey GUI Extension
  (chocolatey#2227) Use latest Mono and Ubuntu on Travis
  (chocolatey#2205) Remove mention of private repository
  (chocolatey#2205) Update remaining URLs to new location
  (maint) Remove unnecessary whitespace
  (chocolatey#2231) Change default repository URL
  (maint) Remove unnecessary whitespace
  (chocolatey#2205) Update all chocolatey.org/docs URLs
  (maint) Remove unnecessary whitespace
  (chocolatey#2205) Update automatic-packages docs links
  (doc) Update to prefer # rather than GH-
  (maint) Fix replacement
  (maint) Revert change to earlier commit
  (maint) Fix spelling mistake
  (maint) Fix spelling mistake
  (doc) Update script to Statiq format
  (maint) Add missing backtick in example
  (maint) Added explicit link to new function name
  (maint) Fix spelling mistake
  (maint) Fix spelling mistake
  (maint) Fix spelling mistake
  (maint) Fix spelling mistake
  (maint) Fix spelling mistake
  (maint) Fix spelling mistake
  (maint) Remove generated docs files
  (maint) Add docs/generated folder to ignore list
  (chocolateyGH-2105) Update link to Chocolatey workshop
@gep13 gep13 changed the title Remove unused variable in uninstall template Remove unused variable in uninstall template generated from choco new command May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
5 - Released Improvement Priority_LOW
Projects
None yet
Milestone
0.11.0
Development

Successfully merging a pull request may close this issue.

Remove unused variable
3 participants
@ferventcoder @gep13 @DdOtzen