Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Working directory always being replaced with configured cache location when using Start-ChocolateyProcessAsAdmin #2051

Closed
ferventcoder opened this issue May 16, 2020 · 2 comments
Closed

Working directory always being replaced with configured cache location when using Start-ChocolateyProcessAsAdmin #2051

ferventcoder opened this issue May 16, 2020 · 2 comments
Assignees
@ferventcoder
Labels
5 - Released Bug Priority_HIGH
Milestone
0.11.0

Comments

@ferventcoder
Copy link
Member

ferventcoder commented May 16, 2020 •
edited
Loading

As a result of #1781, which was implemented in Chocolatey v0.10.14, the working directory path is always being replaced with cacheLocation / TEMP for Start-ChocolateyProcessAsAdmin.
@ifreislich ifreislich mentioned this issue May 16, 2020
Closed
@ferventcoder ferventcoder self-assigned this May 16, 2020
@ferventcoder ferventcoder added this to the 0.10.16 milestone May 16, 2020
@ferventcoder ferventcoder mentioned this issue May 16, 2020
Closed
@ferventcoder
Copy link
Member Author

This is completed and will be released in 0.10.16.

@ferventcoder ferventcoder changed the title Get-ChocolateyUnzip / Start-ChocolateyProcessAsAdmin - Path always being replaced with cacheLocation Start-ChocolateyProcessAsAdmin - workingDirectory always being replaced with cacheLocation May 16, 2020
ferventcoder pushed a commit that referenced this issue May 16, 2020
@ferventcoder
(GH-2051) Fix: workingDirectory always replaced w/cacheLocation
02ea65e 
The previous commit 9e2e49a to address UNC paths broke the ability to
provide a working directory to the Start-ChocolateyProcessAsAdmin
helper function. The test `$workingDirectory.ProviderPath -eq $null`
always evaluates to true because the String type does not have the
member ProviderPath.

The fix is to obtain the location object only when no path is provided
to the helper and to verify its validity before use, possibly falling
back to the cache location, similar to how it was implemented for
Get-ChocolateyUnzip.
ferventcoder added a commit that referenced this issue May 16, 2020
@ferventcoder
Merge branch 'pr2006' into stable
8d78c0a 
* pr2006:
  (GH-2051) Fix: workingDirectory always replaced w/cacheLocation
ferventcoder added a commit that referenced this issue May 16, 2020
@ferventcoder
Merge branch 'stable'
8a8559f 
* stable:
  (GH-2051) Fix: workingDirectory always replaced w/cacheLocation
  (GH-1983) exit-on-reboot-detected environment variable
  (maint) update resharper settings
  (maint) formatting
johnstevenson added a commit to johnstevenson/choco that referenced this issue Jun 20, 2020
@johnstevenson
Merge remote-tracking branch 'upstream/master'
09f44ca 
* upstream/master: (21 commits)
  (doc) Changed cla links from clahub to cla-assistant
  (chocolateyGH-2055) remove logs/config folder in nupkg
  (version) 0.10.16-beta
  (chocolateyGH-2023) Install git in the docker container
  (chocolateyGH-1859) Fix error message for missing 32-bit URL
  (chocolateyGH-1859) Fix error message for missing 32-bit URL
  (chocolateyGH-2051) Fix: workingDirectory always replaced w/cacheLocation
  (chocolateyGH-1983) exit-on-reboot-detected environment variable
  (maint) update resharper settings
  (maint) formatting
  (chocolateyGH-1843) Fix: search exact all versions returns 1
  (chocolateyGH-1020) fix build
  (chocolateyGH-1020) Direct platform only for windows tests
  (chocolateyGH-1020) WindowsOnly tests by platform, not ignore
  (chocolateyGH-1020) Docker add ChocolateyInstall Env Var
  (chocolateyGH-1020) Docker use code_drop instead of build_output
  (doc) Update mono installation instructions in README
  (chocolateyGH-1020) Dockerfile and Travis to Mono 5.20.1
  (chocolateyGH-1020) Add mono-4.5 configuration
  Add missing start of comment block
  ...
@ferventcoder
Copy link
Member Author

There is a beta of this at https://chocolatey.org/packages/chocolatey/0.10.16-beta-20200806

gep13 added a commit to gep13/choco that referenced this issue Mar 1, 2021
@gep13
(chocolatey#2051) Make parameter description consistent
ae7f187 
In an earlier commit, the default value of the WorkingDirectory
parameter was changed to be $null, but the parameter description wasn't
updated.
@gep13 gep13 changed the title Start-ChocolateyProcessAsAdmin - workingDirectory always being replaced with cacheLocation Working directory always being replaced with configured cache location when using Start-ChocolateyProcessAsAdmin May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ferventcoder ferventcoder

Labels
5 - Released Bug Priority_HIGH
Projects
None yet
Milestone
0.11.0
Development

Successfully merging a pull request may close this issue.

(GH-2051) Fix: workingDirectory is always relpaced with the cache location
2 participants
@ferventcoder @gep13