Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Api Key & Source matching could be more intuitive #238

Closed
bc3tech opened this issue Apr 10, 2015 · 1 comment
Closed

Api Key & Source matching could be more intuitive #238

bc3tech opened this issue Apr 10, 2015 · 1 comment
Assignees
@ferventcoder
Labels
5 - Released Improvement Up For Grabs
Milestone
0.9.9.5

Comments

@bc3tech
Copy link
Contributor

bc3tech commented Apr 10, 2015

See #234. Ran in to a bit of confusion as I added an apikey for https://chocolatey.org but it wasn't being used because choco was looking for one for https://chocolatey.org/ (note the trailing slash)
Seems to me some logic could be put in place for looking up stored api keys for sources that perhaps ignores a trailing slash? Not sure what else PowerShell might have in its bag of tricks for URL parsing/equality.

I believe I've encountered a similar issue in NuGet, but the choco team's just a tad bit more responsive ;)
@gep13
Copy link
Member

gep13 commented Apr 10, 2015

@bc3tech said...
I believe I've encountered a similar issue in NuGet, but the choco team's just a tad bit more responsive ;)

That is good to hear 👍

@ferventcoder ferventcoder added this to the 0.9.9.5 milestone Apr 20, 2015
@ferventcoder ferventcoder self-assigned this Apr 20, 2015
ferventcoder added a commit to ferventcoder/choco that referenced this issue Apr 20, 2015
@ferventcoder
(chocolateyGH-238) ApiKey source matching intuitive
cdc6b50 
When matching a source versus the passed in source, be a little more
intuitive about the source itself by matching without the end `/`.
ferventcoder added a commit that referenced this issue Apr 20, 2015
@ferventcoder
Merge branch 'stable'
2ed0d63 
* stable: (22 commits)
  (GH-121) Making Uninstall-ChocolateyZipPackage more robust when
deleting files that were copied during installation of the Zip package
  (doc) update changelog/nuspec
  (GH-238) ApiKey source matching intuitive
  (maint) formatting
  (GH-240) Set CredentialProvider for NuGet
  (GH-240) ChocolateyNugetCredentialProvider
  (GH-240) Add default sources to machine sources
  (maint) Only warn subcommand list if not empty
  (GH-171) Use RedirectedHttpClient
  (GH-240) pass credentials at runtime
  (GH-240)(config) Add machine sources
  (doc) how to quote values
  (GH-230) Export all functions and aliases imported
  (GH-230) Fix Issues with Generate/Remove BinFile
  (GH-185) Remove console prompt default choices
  (GH-186) Uninstall - no prompt for one version
  (GH-182) Ask before printing ps1 scripts
  (GH-187) Show log file path in messages.
  (maint) formatting
  (GH-169) Do not resolve disabled sources
  ...

Conflicts:
	src/chocolatey/infrastructure.app/commands/ChocolateySourceCommand.cs
	src/chocolatey/infrastructure.app/runners/GenericRunner.cs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ferventcoder ferventcoder

Labels
5 - Released Improvement Up For Grabs
Projects
None yet
Milestone
0.9.9.5
Development

No branches or pull requests
3 participants
@ferventcoder @gep13 @bc3tech