Fix Issues with Generate-BinFile / Remove-BinFile

[gep13]

0.9.9.4 of Chocolatey added back in the ability to use the Generate-BinFile and the Remove-BinFile cmdlets.

However, looks like there is still an issue when using them.

This is related to #195 and #145

When doing the above linked issues, it was believed that the $nugetExePath (which is used within these scripts) would already be available from the calling module, however, it looks like this is not the case.

Steps to reproduce:

• choco install githubreleasemanager.portable -y

Output:

 Join-Path : Cannot bind argument to parameter 'Path' because it is null.
 At C:\ProgramData\chocolatey\helpers\functions\Generate-BinFile.ps1:24 char:37
 +   $packageBatchFileName = Join-Path $nugetExePath "$name.bat"
 +                                     ~~~~~~~~~~~~~
     + CategoryInfo          : InvalidData: (:) [Join-Path], ParameterBindingVa
    lidationException
     + FullyQualifiedErrorId : ParameterArgumentValidationErrorNullNotAllowed,M
    icrosoft.PowerShell.Commands.JoinPathCommand
 Join-Path : Cannot bind argument to parameter 'Path' because it is null.
 At C:\ProgramData\chocolatey\helpers\functions\Generate-BinFile.ps1:25 char:36
 +   $packageBashFileName = Join-Path $nugetExePath "$name"
 +                                    ~~~~~~~~~~~~~
     + CategoryInfo          : InvalidData: (:) [Join-Path], ParameterBindingVa
    lidationException
     + FullyQualifiedErrorId : ParameterArgumentValidationErrorNullNotAllowed,M
    icrosoft.PowerShell.Commands.JoinPathCommand
 Join-Path : Cannot bind argument to parameter 'Path' because it is null.
 At C:\ProgramData\chocolatey\helpers\functions\Generate-BinFile.ps1:26 char:36
 +   $packageShimFileName = Join-Path $nugetExePath "$name.exe"
 +                                    ~~~~~~~~~~~~~
     + CategoryInfo          : InvalidData: (:) [Join-Path], ParameterBindingVa
    lidationException
     + FullyQualifiedErrorId : ParameterArgumentValidationErrorNullNotAllowed,M
    icrosoft.PowerShell.Commands.JoinPathCommand
 Test-Path : Cannot bind argument to parameter 'Path' because it is null.
 At C:\ProgramData\chocolatey\helpers\functions\Generate-BinFile.ps1:28 char:17
 +   if (Test-Path ($packageBatchFileName)) {Remove-Item $packageBatchFileName -
 for ...
 +                 ~~~~~~~~~~~~~~~~~~~~~~~
     + CategoryInfo          : InvalidData: (:) [Test-Path], ParameterBindingVa
    lidationException
     + FullyQualifiedErrorId : ParameterArgumentValidationErrorNullNotAllowed,M
    icrosoft.PowerShell.Commands.TestPathCommand
 Test-Path : Cannot bind argument to parameter 'Path' because it is null.
 At C:\ProgramData\chocolatey\helpers\functions\Generate-BinFile.ps1:29 char:17
 +   if (Test-Path ($packageBashFileName)) {Remove-Item $packageBashFileName -fo
 rce ...
 +                 ~~~~~~~~~~~~~~~~~~~~~~
     + CategoryInfo          : InvalidData: (:) [Test-Path], ParameterBindingVa
    lidationException
     + FullyQualifiedErrorId : ParameterArgumentValidationErrorNullNotAllowed,M
    icrosoft.PowerShell.Commands.TestPathCommand
 You cannot call a method on a null-valued expression.
 At C:\ProgramData\chocolatey\helpers\functions\Generate-BinFile.ps1:31 char:3
 +   $path = $path.ToLower().Replace($nugetPath.ToLower(), "..\").Replace("\\","
 \")
 +   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

 + CategoryInfo          : InvalidOperation: (:) [], RuntimeException
 + FullyQualifiedErrorId : InvokeMethodOnNull

Test-Path : Cannot bind argument to parameter 'Path' because it is null.
At C:\ProgramData\chocolatey\helpers\functions\Generate-BinFile.ps1:70 char:17

• if (Test-Path ($packageShimFileName)) {

•             ~~~~~~~~~~~~~~~~~~~~~~
  

  • CategoryInfo : InvalidData: (:) [Test-Path], ParameterBindingVa
    lidationException
  • FullyQualifiedErrorId : ParameterArgumentValidationErrorNullNotAllowed,M
    icrosoft.PowerShell.Commands.TestPathCommand
    githubreleasemanager.portable install not successful.
    Error while running 'C:\ProgramData\chocolatey\lib\githubreleasemanager.portable\tools\chocolateyInstall.ps1'.
    See log for details.

Chocolatey installed 0/1 package(s). 1 package(s) failed.
See the log for details.
Failures:

• githubreleasemanager.portable