Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add deprecation notices for all things that are set to change in v2.0.0 #2462

Closed
gep13 opened this issue Nov 18, 2021 · 2 comments · Fixed by #2626
Closed

Add deprecation notices for all things that are set to change in v2.0.0 #2462

gep13 opened this issue Nov 18, 2021 · 2 comments · Fixed by #2626
Assignees
@AdmiringWorm
Labels
5 - Released Documentation IN REGRESSION TEST SUITE These are things that are handled by tools like Test-Kitchen
Milestone
1.0.0

Comments

@gep13
Copy link
Member

gep13 commented Nov 18, 2021 •
edited
Loading

The following are items that are planned to be completed in v2.0.0 of Chocolatey, we need to add notices, both in code and in the docs, to ensure that these changes are well communicated prior to this change.
@gep13 gep13 added this to the 1.0.0 milestone Nov 18, 2021
@TheCakeIsNaOH
Copy link
Member

Issue for documenting Get-BinRoot is deprecated: https://github.com/chocolatey/choco/issues/339

@TheCakeIsNaOH
Copy link
Member

And this issue about it probably should also be closed? #65

@corbob corbob added the ADD AUTO TESTS Things that typically go to Test-Kitchen - once completed, IN REGRESSION TEST SUITE label added label Mar 1, 2022
@AdmiringWorm AdmiringWorm self-assigned this Mar 7, 2022
AdmiringWorm added a commit to AdmiringWorm/choco that referenced this issue Mar 8, 2022
@AdmiringWorm
(chocolatey#2462) Deprecate remote args for list command
2fc8d52 
This commit updates the list command to deprecate
the argument `--local-only` and arguments only valid
for remote sources when running the list command,
with a message that list will be made local only by default
in v2.0.0. The same message mentions to use search or find
instead for remote searches.

There are additionally several messages other places to ensure
that it will be difficult to miss the deprecation of remote
sources when calling the list command.
@AdmiringWorm AdmiringWorm mentioned this issue Mar 8, 2022
Merged
9 tasks
AdmiringWorm added a commit to AdmiringWorm/choco that referenced this issue Mar 9, 2022
@AdmiringWorm
(chocolatey#2462) Deprecate remote args for list command
45265d9 
This commit updates the list command to deprecate
the argument `--local-only` and arguments only valid
for remote sources when running the list command,
with a message that list will be made local only by default
in v2.0.0. The same message mentions to use search or find
instead for remote searches.

There are additionally several messages other places to ensure
that it will be difficult to miss the deprecation of remote
sources when calling the list command.
gep13 pushed a commit to AdmiringWorm/choco that referenced this issue Mar 10, 2022
@AdmiringWorm @gep13
(chocolatey#2462) Deprecate remote args for list command
971290a 
This commit updates the list command to deprecate
the argument `--local-only` and arguments only valid
for remote sources when running the list command,
with a message that list will be made local only by default
in v2.0.0. The same message mentions to use search or find
instead for remote searches.

There are additionally several messages other places to ensure
that it will be difficult to miss the deprecation of remote
sources when calling the list command.
gep13 added a commit to AdmiringWorm/choco that referenced this issue Mar 10, 2022
@gep13
(chocolatey#2462) Minor tweak to wording of messages
dc8902d 
This meant an update to the unit tests that are asserting on this
message being shown.
gep13 added a commit that referenced this issue Mar 10, 2022
@gep13
Merge pull request #2626 from AdmiringWorm/2462-Add-deprecation-notic…
49c781f 
…es-for-all-things-that-are-set-to-change-in-v200

(#2462) Add deprecation notices for list with remote sources before making it local only
@gep13 gep13 added 4 - Done and removed 3 - Review labels Mar 10, 2022
@AdmiringWorm AdmiringWorm mentioned this issue Mar 10, 2022
Merged
10 tasks
AdmiringWorm added a commit to AdmiringWorm/choco that referenced this issue Mar 10, 2022
@AdmiringWorm
(chocolatey#2462) Remove mention of alias for search comand
afba28f 
This commit updates the registration for the search
command/alias to no longer mention it being an alias
for the search command.

This is done so it will look like that list and search
is not the same handler, as the list command itself will
be made local only in v2.0.0

This was somehow missed when deprecating the remote arguments
when list is called
@corbob corbob added IN REGRESSION TEST SUITE These are things that are handled by tools like Test-Kitchen and removed ADD AUTO TESTS Things that typically go to Test-Kitchen - once completed, IN REGRESSION TEST SUITE label added labels Mar 11, 2022
gep13 added a commit that referenced this issue Mar 18, 2022
@gep13
Merge branch 'release/1.0.0'
5c9117a 
* release/1.0.0: (65 commits)
  (version) v1.0.0
  (#2443) Fix misspellings for profile text
  (#2468) Remove choco update command
  (#2468) Remove choco version command
  (#2602) Add 1.0.0 of shimgen and update shims
  (#89) Remove cpack shims on package upgrades
  (#89) Remove cpack shim for choco pack
  (maint) Update deprecation notice for config settings
  (build) Additional tweaks to version numbers
  (build) Add SolutionVersion.cs file to artifacts
  (docs) Update committers docs with correct/fixed links
  (build) Minor tweaks to build files
  (#2615) Reference CREDITS file for other licenses
  (build) Refactor Nuget Upload
  (build) Added missing Kotlin import
  (maint) Whitespace
  (#2614) Update 7zip / Shimgen licenses
  (#2614) Update project  contributors
  (#2641) Minor tweaks to wording and formatting
  (#2462) Remove mention of alias for search comand
  ...
@pauby pauby mentioned this issue May 31, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AdmiringWorm AdmiringWorm

Labels
5 - Released Documentation IN REGRESSION TEST SUITE These are things that are handled by tools like Test-Kitchen
Projects
None yet
Milestone
1.0.0
4 participants
@gep13 @AdmiringWorm @corbob @TheCakeIsNaOH