Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure nupkg is removed on uninstall no matter what NuGet reports #254

Closed
ferventcoder opened this issue Apr 22, 2015 · 0 comments
Closed
Assignees
Milestone

Comments

@ferventcoder
Copy link
Member

NuGet will happily tell you that something uninstalled successfully, even if it didn't.

So we get reports that after uninstalling, it is still reported to be installed. Using force will actually clean it up though.

@ferventcoder ferventcoder added this to the 0.9.9.6 milestone Apr 22, 2015
ferventcoder added a commit that referenced this issue Apr 22, 2015
NuGet will happily tell you that something has been uninstalled, even
if it didn't actually remove the nupkg from the folder. At the very
least we need an additional check to ensure the nupkg file is removed
in case NuGet has an issue removing the file.

Without this change the package may still be considered installed and
cause bad side effects when doing things like `cup all` or trying to
reinstall the package. This also resolves the requirement for cases
like this in using `--force` to remove the package.
ferventcoder added a commit that referenced this issue Apr 22, 2015
* stable:
  (GH-212) Do not strip switch char from uninstall args
  (maint) Use installshield installer when installshield
  (GH-255) Uninstaller should not depend on InstallLocation
  (GH-255) Add updateProcessPath to CommandExecutor
  (maint) formatting
  (GH-254) Ensure nupkg is removed on uninstall
  (doc) update help menus
@ferventcoder ferventcoder self-assigned this Apr 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants